[asterisk-bugs] [Asterisk 0012890]: notifyringing option comment in configs/sip.conf.sample

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12890 
====================================================================== 
Reported By:                gminet
Assigned To:                svnbot
====================================================================== 
Project:                    Asterisk
Issue ID:                   12890
Category:                   Documentation
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.4.21-rc1 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             06-19-2008 07:50 CDT
Last Modified:              06-19-2008 11:15 CDT
====================================================================== 
Summary:                    notifyringing option comment in
configs/sip.conf.sample
Description: 
I _think_ the comment in sip.conf.sample regarding the notifyringing option
(and the option name itself, but that's another story) are quite
misleading. 
Based on the original patch that implemented that option and on my reading
of the source code, this option doesn't control the whole ringing state
notification as suggested. The ringing ("early" ) notification is always
sent regardless the actual value of the option.

Instead it controls whether a second RINGING channel on a already INUSE
hint should be notified as INUSE ("confirmed") or RINGING ("early"). 


====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 06-19-08 11:15  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 123891

_U  branches/1.6.0/
U   branches/1.6.0/configs/sip.conf.sample

------------------------------------------------------------------------
r123891 | tilghman | 2008-06-19 11:15:11 -0500 (Thu, 19 Jun 2008) | 20
lines

Merged revisions 123887 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
r123887 | tilghman | 2008-06-19 11:21:32 -0500 (Thu, 19 Jun 2008) | 12
lines

Merged revisions 123883 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123883 | tilghman | 2008-06-19 11:20:41 -0500 (Thu, 19 Jun 2008) | 4
lines

Correct description of notifyringing option.
(Closes issue http://bugs.digium.com/view.php?id=12890)
Reported by gminet

........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=123891 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-19-08 11:15  svnbot         Checkin                                      
06-19-08 11:15  svnbot         Note Added: 0088934                          
======================================================================