[asterisk-bugs] [Asterisk 0012891]: Incorrect format of events send to the child's stdin - missing second coma.

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12891 
====================================================================== 
Reported By:                chris-mac
Assigned To:                svnbot
====================================================================== 
Project:                    Asterisk
Issue ID:                   12891
Category:                   Applications/app_externalivr
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 123826 
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             06-19-2008 08:31 CDT
Last Modified:              06-19-2008 10:47 CDT
====================================================================== 
Summary:                    Incorrect format of events send to the child's stdin
- missing second coma.
Description: 
Events are not sent in the correct format:
tag,timestamp[,data]

second comma is missing eg: "F,1213882295vm-messages"

I think I already found a fix: 

trunk/apps/app_externalivr.c:

Line 121 is:     ast_str_append(&tmp, 0, "%s", data);
should be:       ast_str_append(&tmp, 0, ",%s", data);

However as I never coded single line for *, please verify the above.

Regards,
Chris
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 06-19-08 10:47  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 123866

_U  branches/1.6.0/

------------------------------------------------------------------------
r123866 | tilghman | 2008-06-19 10:47:07 -0500 (Thu, 19 Jun 2008) | 11
lines

Blocked revisions 123865 via svnmerge

........
r123865 | tilghman | 2008-06-19 10:52:17 -0500 (Thu, 19 Jun 2008) | 4
lines

Missing comma
(closes issue http://bugs.digium.com/view.php?id=12891)
 Reported by: chris-mac

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=123866 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-19-08 10:47  svnbot         Checkin                                      
06-19-08 10:47  svnbot         Note Added: 0088925                          
======================================================================