[asterisk-bugs] [Asterisk 0012781]: Queue holdtime smoothing filter is not boxcar (FIR), but exponential average (IIR).

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12781 
====================================================================== 
Reported By:                davidw
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   12781
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   text
Priority:                   normal
Status:                     new
Asterisk Version:           1.4.20.1 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             06-03-2008 13:01 CDT
Last Modified:              06-17-2008 07:48 CDT
====================================================================== 
Summary:                    Queue holdtime smoothing filter is not boxcar (FIR),
but exponential average (IIR).
Description: 
The comment for recalc_holdtime says that it implements a recursive boxcar
algorithm.  Even with the "recursive" qualifier, boxcar averaging refers to
simple rolling average filters, which are finite impulse response ones. 
The filter that recalc_holdtime actually implements is an exponential
average, which is an infinite impulse response filter.


====================================================================== 

---------------------------------------------------------------------- 
 davidw - 06-17-08 07:48  
---------------------------------------------------------------------- 
I marked it as text, because I was suggesting the comment be changed. 
Basically I was hoping it was a bit more sophisticated than it is, and
didn't recognize the "boxcar" term,  but when I looked it up I found that
it was being misused. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-17-08 07:48  davidw         Note Added: 0088797                          
======================================================================