[asterisk-bugs] [Asterisk 0012862]: incorrect state update in friend nodes (chan_sip.c)

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12862 
====================================================================== 
Reported By:                mojadita
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   12862
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.4.19 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             06-15-2008 15:52 CDT
Last Modified:              06-16-2008 04:14 CDT
====================================================================== 
Summary:                    incorrect state update in friend nodes (chan_sip.c)
Description: 
I have noticed that when devices are being monitored for NOTICE events,
when two extensions call each other only the destination one is marked as
busy.  This issue was discovered with a Linksys SPA-962 with SPA-932 button
attendant used to monitor the SIP extensions status.

Following the code I have observed that when a call is being made from a
sip friend, only the user part is being updated for state (on the calling
side) but not the peer part for friends, and when it is consulted, only the
peer part gets involved for status (and not the user part in case of a
friend).

I have modified chan_sip.c to update the peer part for peers/friends and
the user part for users only, and the sip_devicestate routine to do the
same when asking for status.  Now, both extensions (the calling and the
called one) activate their busy lights when monitored.

I have published a patch to update the code as I don't have developer
status, patch is at
http://www.lcssl.es/~luis/asterisk_patches/patch_correct_state.patch
please, feel free to check it (it's been developed for 1.4.19, but it
applies well on 1.4.20 and probably to 1.4.21, sorry for the inconvenience)
and incorporate to the main trunk if possible (granted will be a mention of
my two cents contribution, if possible)  Feel free of checking it, as it's
a very short one.

Thanks for your attention.

Luis Colorado
====================================================================== 

---------------------------------------------------------------------- 
 mojadita - 06-16-08 04:14  
---------------------------------------------------------------------- 
I can sign it.  Just send me the agreement text and procedure application
via fax to +34 949276720 and I'll return it to you as soon as possible.

Luis Colorado

LUIS COLORADO SISTEMAS S.L.
http://www.lcssl.es/ 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-16-08 04:14  mojadita       Note Added: 0088731                          
======================================================================