[asterisk-bugs] [Asterisk 0010668]: Incomplete CDR lock

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10668 
====================================================================== 
Reported By:                arkadia
Assigned To:                murf
====================================================================== 
Project:                    Asterisk
Issue ID:                   10668
Category:                   CDR/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.4.11  
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             09-07-2007 08:26 CDT
Last Modified:              06-09-2008 15:05 CDT
====================================================================== 
Summary:                    Incomplete CDR lock
Description: 
This is all about the meaning of AST_CDR_FLAG_LOCKED flag for CDR. 
I assume if CDR has this flag set then it wont be updated anymore by any
ast_cdr_ functions except cases when we force such update. ast_cdr_reset()
is example of function which allows to update locked CDRs if special flag
is given.

Based on this assumption I prepared the patch with such changes:

  ast_cdr_setvar() - not allowed to touch locked CDRs. I don't see any
cases when we need to change locked CDRs too. Not touching locked CDRs is
helpfull when ForkCDR being used and every new CDR may have different
custom variables.

  ast_cdr_answer() - don't change status of locked CDRs. That might be
helpfull when we have a chain of CDRs for one incoming call for which we
perform several tries to make outgoing call. Every outgoing attempt may
finish with its own completion code. And if the final attempt is 'answered'
then we have only one CDR with 'answered' status. All other will keep
connection error codes which is very helpful for error monitoring.

 ast_cdr_end() - don't change locked CDRs by the same reason as
ast_cdr_answer()

As there will be no changes in CDR after lock, app_forkcdr.c should be
updated to end original locked CDR.
Also it'll be great to make optional cdr reset in this application, but
thats a theme for another patch.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0012726 ForkCDR application fails to set duration
====================================================================== 

---------------------------------------------------------------------- 
 arkadia - 06-09-08 15:05  
---------------------------------------------------------------------- 
> As to changing the setvar func to make it so it doesn't touch LOCKED
> cdrs, well, my reaction is no. The way ForkCDR is constructed,
> all CDR's but the last in a chain will be locked. Thus, you get
> this behavior without anything needing to be changed, if you 
> use the CDR() func with the 'l' option (small-L). (after I commit
> the change to make CDR honor the 'l' in writing).

I'm not using CDR() at all. I'm using ast_cdr_setvar() directly from my
applications.
Thats why I'm talking about adding LOCK to this function. Otherwise the
code which meant to be there will be in user applications everywhere you
need to set variable. I see you've got this point adding:

 if (dont_touch_locked && ast_test_flag(cdr, AST_CDR_FLAG_LOCKED))
	continue;

I prefer we use same kind of construction all over cdr.c like:

 if (ast_test_flag(cdr, AST_CDR_FLAG_DONT_TOUCH_LOCKED) &&
ast_test_flag(cdr, AST_CDR_FLAG_LOCKED))
	continue;

without introducing extra AST_CDR_FLAG_ANSLOCKED.

If you put this code in ast_cdr_answer, ast_cdr_setvar and ast_cdr_end
I'll be happy. Nothing else needs to be done in cdr.c. 
In this case ForkCDR and CDR() will work as before without any necessity
to adjust them. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-09-08 15:05  arkadia        Note Added: 0088505                          
======================================================================