[asterisk-bugs] [Zaptel 0012813]: [patch] race conditions in wct4xxp

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12813 
====================================================================== 
Reported By:                aks
Assigned To:                
====================================================================== 
Project:                    Zaptel
Issue ID:                   12813
Category:                   wct4xxp
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     new
Zaptel Version:             1.4.11 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             06-09-2008 05:15 CDT
Last Modified:              06-09-2008 08:20 CDT
====================================================================== 
Summary:                    [patch] race conditions in wct4xxp
Description: 
I think that you have a few race conditions bugs

====================================================================== 

---------------------------------------------------------------------- 
 aks - 06-09-08 08:20  
---------------------------------------------------------------------- 
we have contacted with support David Faulk + Aaron Daniel. Firmware was
upgadated (for HDLC Errors) + in __t4_pci_out Function of
zaptel-1.4.11/kernel/wct4xxp/base.c was udelay(3) removed!!!
Comment to patch:
in 
__t4_pci_out will be  
 writel(value, &wc->membase[addr]) called
...
then will be called 
udelay(3) 
...
then will be called  (for mmio flushing)
 __t4_pci_in(wc, WC_VERSION);

it means, that  writel will be later flushed


The right order is
 writel(value, &wc->membase[addr]) called
 __t4_pci_in(wc, WC_VERSION); (to initiate flushing)
udelay(3)

And 2 missng spinlocks im patch 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-09-08 08:20  aks            Note Added: 0088475                          
======================================================================