[asterisk-bugs] [Asterisk 0011688]: patch to allow Sipura handsets (SPA942) to use Asterisk SLA via implementation of Broadsoft Sip extensions

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11688 
====================================================================== 
Reported By:                grossi
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   11688
Category:                   Channels/chan_sip/NewFeature
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.4.16.2 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 96644 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             01-05-2008 10:58 CST
Last Modified:              06-07-2008 15:59 CDT
====================================================================== 
Summary:                    patch to allow Sipura handsets (SPA942) to use
Asterisk SLA via implementation of Broadsoft Sip extensions
Description: 
Modifications in chan_sip.c and pbx.h to accommidate rudimentary
implementation of Broadsoft SIP Access side extensions with the short term
goal of achieving SLA functionality for Sipura phones (tested on SPA942's)
. 

Currently I have full SLA compatability with SPA942's working as well as
integration with other (AASTRA 53i) SLA compatible phones on asterisk. 


====================================================================== 

---------------------------------------------------------------------- 
 mvanbaak - 06-07-08 15:59  
---------------------------------------------------------------------- 
+	if ((p->subscribed == CALL_INFO) | (state == AST_EXTENSION_REQLINESEIZE))
{
+		}
+	else {

that looks wrong to me.
If you dont do anything when those parts are set you should use the
negative check
something like:
if (foo != bar & baz != zoo) { 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-07-08 15:59  mvanbaak       Note Added: 0088438                          
======================================================================