[asterisk-bugs] [Asterisk 0012160]: [patch] channel alarm set when a channel is opened

noreply at bugs.digium.com noreply at bugs.digium.com
Sat Jun 7 13:55:13 CDT 2008 

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12160 
====================================================================== 
Reported By:                tzafrir
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   12160
Category:                   Channels/chan_zap
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 106393 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             03-06-2008 10:11 CST
Last Modified:              06-07-2008 13:55 CDT
====================================================================== 
Summary:                    [patch] channel alarm set when a channel is opened
Description: 
If a channel alarm is already set when a channel is opened by Asterisk,
whose responsibility is it to check for the alarms?

1. The channe l driver should detect that and re-send alarms on zt_open

2. Zaptel should  send an alarm event at channel open time. The
applicaiton opening the channel should then be able to read those events
and will have the proper information.

3. The application should read channel alarms at channel initialization
time. No need for Zaptel to send extra events.

As senseless as (1) is, it has been used in practice by the xpp d FXO
module driver. I figure you all agree with me it is not the way to go.


The behaviour with regards to span alarm seems in Asterisk seems to be
(3).

Attached are patches implementing both (2) and (3)
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 06-07-08 13:55  
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 3989

_U  team/mattf/zaptel-1.4-vpmadt032fwupdate/
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/Makefile
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/README
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/wct4xxp/base.c
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/.version
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/Changelog_xpp
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/Kbuild
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/README.Astribank
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/calibrate_slics
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/card_bri.c
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/card_fxo.c
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/card_fxs.c
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/card_global.c
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/card_pri.c
U  
team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/firmwares/FPGA_1141.hex
U  
team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/firmwares/FPGA_1151.hex
U  
team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/firmwares/FPGA_FXS.hex
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/init_card_3_29
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/utils/Makefile
U  
team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/utils/astribank_hook
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/utils/xpp.rules
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/utils/xpp_fxloader
A   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/utils/xpp_timing
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/utils/zapconf
U  
team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/utils/zconf/Zaptel/Hardware/PCI.pm
U  
team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/utils/zconf/Zaptel/Span.pm
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/xbus-core.c
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/xbus-core.h
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/xbus-pcm.c
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/xbus-pcm.h
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/xbus-sysfs.c
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/xdefs.h
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/xframe_queue.c
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/xpp_usb.c
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/xpp_zap.c
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/xpp/xproto.c
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/kernel/zaptel-base.c
U   team/mattf/zaptel-1.4-vpmadt032fwupdate/zaptel.conf.sample

------------------------------------------------------------------------
r3989 | mattf | 2008-06-07 13:55:10 -0500 (Sat, 07 Jun 2008) | 125 lines

Merged revisions 3953,3957-3958,3964,3969,3973,3976,3979,3983-3984 via
svnmerge from 
https://origsvn.digium.com/svn/zaptel/branches/1.4

........
r3953 | tzafrir | 2008-03-06 17:40:49 -0600 (Thu, 06 Mar 2008) | 2 lines

Blocking the 'make clean' fix.

........
r3957 | tzafrir | 2008-03-06 18:45:53 -0600 (Thu, 06 Mar 2008) | 58 lines

xpp.r5512:
* Build:
  - Zaptel >= 1.4.9 is migrating to storing kernel stuff in
zaptel/kernel/*
  -  We conditionally use old/new directory scheme:
     In xpp/Kbuild and xpp/utils/Makefile use ZAP_KERNEL variable, so it's
     not confused with ZAPTEL_DIR (which appears in zaptel/Makefile as
well).
  - Fix compile warnings on 64 bit systems.
  - Compile fixes for kernel-2.6.24
* UDEV:
  - /etc/udev/rules.d/xpp.rules now uses XPP_INIT_DIR to find
astribank_hook.
  - astribank_hook: Modify to do nothing. Add some documentation.
* Autoconfiguration -- zapconf:
  - Don't fail zapconf et.al. if no config file was found.
  - Skip the 'IRQ Missing:' line in /proc/zaptel/nnn for wcte1xp(?).
  - Add some newer Digium cards to our hardware inventory.
  - Partially handle cases where the /proc/zaptel strings does not contain
    info about E1/T1/J1 or NT/TE.
* Better SYNC:
  - Finer tuning of PLL (New firmware).
  - Change calculation algorithm of sync offset. It now copes better
    with the variance in USB frame reception timing.
  - Statistics:
    . The view of results was moved from /proc/xpp/XBUS-*/summary to
      a new /sys/bus/astribanks/devices/xbus-*/timing and enhanced.
    . A new xpp_timing script shows all astribanks.
    . A new write only /sys/bus/astribanks/devices/xbus-*/cls is
      used to clear statistics. Eventually, clearing of XBUS related
      statistics should be done here. One that was migrated is the
      clearing of 'PCM [TR]X:' numbers currently appearing in
      /proc/xpp/XBUS-*/summary (they should be moved too later).
  - Shorten the strings representation sync_mode ("SYNC_MODE_AB" -> "AB")
    adapted their use in printk and /proc so the text is clear.
  - Added a command line parameter xpp.disable_pll_sync to stop all
    adjustments command to AB (calculations still continue as usual).
* PRI:
  - 4 port support
  - set clocking master span via ztcfg, like other zaptel devices.
* FXO:
  - Fix false hangups in some countries (voltage fluctuations).
  - Some countries send caller-id before first ring.
    Added code to handle caller-id PCM pass through according to
    a new command line parameter (xpd_fxo.caller_id_style).
  - No longer sends an event on zt_open. See
http://bugs.digium.com/view.php?id=12160 .
* Misc:
  - Adapt to zaptel-1.4.8 and above ztscan: added fields returend by
    new ZT_SPANSTAT_V2 ioctl()
  - Document sysfs and waitfor_xpds.
  - Miscelaneous optimizations and bugfixes.
  - Remove deprecated pcm_tasklet parameter. The rx_tasklet parameter has
    replaced it a long time ago.
  - Add RX_CMD counter to /proc/xpp/XBUS-*/summary
  - Unclutter some of the usb disconnect messages.
  - xpp_usb: minor preformance improvements in receive.
    Expose the number of pending receive URB's in /proc/xpp/XBUS-*/xpp_usb

Merged revisions 3952 via svnmerge from 
http://svn.digium.com/svn/zaptel/branches/1.2

........
r3958 | tzafrir | 2008-03-06 19:01:42 -0600 (Thu, 06 Mar 2008) | 2 lines

Also print channel alarms in /proc/zaptel files.

........
r3964 | qwell | 2008-03-07 10:18:13 -0600 (Fri, 07 Mar 2008) | 7 lines

Fix compilation when using devfs

(closes issue http://bugs.digium.com/view.php?id=12156)
Reported by: zandbelt
Patches:
      zaptel-1.4.9.2-devfs-mode.patch uploaded by zandbelt (license 33)

........
r3969 | tzafrir | 2008-03-09 04:51:48 -0500 (Sun, 09 Mar 2008) | 6 lines

Integrating sample / reference configuration file into the reference
documentation.

Merged revisions 3968 via svnmerge from 
http://svn.digium.com/svn/zaptel/branches/1.2

........
r3973 | tzafrir | 2008-03-09 07:06:50 -0500 (Sun, 09 Mar 2008) | 5 lines

More asciidoc polishes and small sample file fixes.

Merged revisions 3972 via svnmerge from 
http://svn.digium.com/svn/zaptel/branches/1.2

........
r3976 | tzafrir | 2008-03-09 09:30:23 -0500 (Sun, 09 Mar 2008) | 6 lines

The main Makefile now knows if we don't have kernel source.
* Nicer handling of situations where we don't have kernel source and
  don't really need it ('make clean', mainly).
* The test for hotplug firmware is now from the same .config file. No
  more strange message about autoconf.h .

........
r3979 | tzafrir | 2008-03-09 13:18:10 -0500 (Sun, 09 Mar 2008) | 2 lines

Hush grep's output once again and allow building with firmware support.

........
r3983 | mattf | 2008-03-14 10:39:17 -0500 (Fri, 14 Mar 2008) | 1 line

Update linked mISDN version to latest (1.1.7.2)
........
r3984 | mattf | 2008-03-14 11:09:15 -0500 (Fri, 14 Mar 2008) | 1 line

When doing the ISR rewrite, forgot to include the vpmdtmfcheck when doing
DTMF polling causing it to check for DTMF events even when it was told not
to
........

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=3989 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-07-08 13:55  svnbot         Note Added: 0088405                          
======================================================================

More information about the asterisk-bugs mailing list