[asterisk-bugs] [Asterisk 0012160]: [patch] channel alarm set when a channel is opened
noreply at bugs.digium.com
noreply at bugs.digium.com
Sat Jun 7 13:54:35 CDT 2008
A NOTE has been added to this issue.
======================================================================
http://bugs.digium.com/view.php?id=12160
======================================================================
Reported By: tzafrir
Assigned To:
======================================================================
Project: Asterisk
Issue ID: 12160
Category: Channels/chan_zap
Reproducibility: always
Severity: minor
Priority: normal
Status: new
Asterisk Version: SVN
SVN Branch (only for SVN checkouts, not tarball releases): trunk
SVN Revision (number only!): 106393
Disclaimer on File?: N/A
Request Review:
======================================================================
Date Submitted: 03-06-2008 10:11 CST
Last Modified: 06-07-2008 13:54 CDT
======================================================================
Summary: [patch] channel alarm set when a channel is opened
Description:
If a channel alarm is already set when a channel is opened by Asterisk,
whose responsibility is it to check for the alarms?
1. The channe l driver should detect that and re-send alarms on zt_open
2. Zaptel should send an alarm event at channel open time. The
applicaiton opening the channel should then be able to read those events
and will have the proper information.
3. The application should read channel alarms at channel initialization
time. No need for Zaptel to send extra events.
As senseless as (1) is, it has been used in practice by the xpp d FXO
module driver. I figure you all agree with me it is not the way to go.
The behaviour with regards to span alarm seems in Asterisk seems to be
(3).
Attached are patches implementing both (2) and (3)
======================================================================
----------------------------------------------------------------------
svnbot - 06-07-08 13:54
----------------------------------------------------------------------
Repository: dahdi
Revision: 3957
_U branches/1.4/
U branches/1.4/kernel/xpp/.version
U branches/1.4/kernel/xpp/Changelog_xpp
U branches/1.4/kernel/xpp/Kbuild
U branches/1.4/kernel/xpp/README.Astribank
U branches/1.4/kernel/xpp/calibrate_slics
U branches/1.4/kernel/xpp/card_bri.c
U branches/1.4/kernel/xpp/card_fxo.c
U branches/1.4/kernel/xpp/card_fxs.c
U branches/1.4/kernel/xpp/card_global.c
U branches/1.4/kernel/xpp/card_pri.c
U branches/1.4/kernel/xpp/firmwares/FPGA_1141.hex
U branches/1.4/kernel/xpp/firmwares/FPGA_1151.hex
U branches/1.4/kernel/xpp/firmwares/FPGA_FXS.hex
U branches/1.4/kernel/xpp/init_card_3_29
U branches/1.4/kernel/xpp/utils/Makefile
U branches/1.4/kernel/xpp/utils/astribank_hook
U branches/1.4/kernel/xpp/utils/xpp.rules
U branches/1.4/kernel/xpp/utils/xpp_fxloader
A branches/1.4/kernel/xpp/utils/xpp_timing
U branches/1.4/kernel/xpp/utils/zapconf
U branches/1.4/kernel/xpp/utils/zconf/Zaptel/Hardware/PCI.pm
U branches/1.4/kernel/xpp/utils/zconf/Zaptel/Span.pm
U branches/1.4/kernel/xpp/xbus-core.c
U branches/1.4/kernel/xpp/xbus-core.h
U branches/1.4/kernel/xpp/xbus-pcm.c
U branches/1.4/kernel/xpp/xbus-pcm.h
U branches/1.4/kernel/xpp/xbus-sysfs.c
U branches/1.4/kernel/xpp/xdefs.h
U branches/1.4/kernel/xpp/xframe_queue.c
U branches/1.4/kernel/xpp/xpp_usb.c
U branches/1.4/kernel/xpp/xpp_zap.c
U branches/1.4/kernel/xpp/xproto.c
------------------------------------------------------------------------
r3957 | tzafrir | 2008-06-07 13:54:34 -0500 (Sat, 07 Jun 2008) | 58 lines
xpp.r5512:
* Build:
- Zaptel >= 1.4.9 is migrating to storing kernel stuff in
zaptel/kernel/*
- We conditionally use old/new directory scheme:
In xpp/Kbuild and xpp/utils/Makefile use ZAP_KERNEL variable, so it's
not confused with ZAPTEL_DIR (which appears in zaptel/Makefile as
well).
- Fix compile warnings on 64 bit systems.
- Compile fixes for kernel-2.6.24
* UDEV:
- /etc/udev/rules.d/xpp.rules now uses XPP_INIT_DIR to find
astribank_hook.
- astribank_hook: Modify to do nothing. Add some documentation.
* Autoconfiguration -- zapconf:
- Don't fail zapconf et.al. if no config file was found.
- Skip the 'IRQ Missing:' line in /proc/zaptel/nnn for wcte1xp(?).
- Add some newer Digium cards to our hardware inventory.
- Partially handle cases where the /proc/zaptel strings does not contain
info about E1/T1/J1 or NT/TE.
* Better SYNC:
- Finer tuning of PLL (New firmware).
- Change calculation algorithm of sync offset. It now copes better
with the variance in USB frame reception timing.
- Statistics:
. The view of results was moved from /proc/xpp/XBUS-*/summary to
a new /sys/bus/astribanks/devices/xbus-*/timing and enhanced.
. A new xpp_timing script shows all astribanks.
. A new write only /sys/bus/astribanks/devices/xbus-*/cls is
used to clear statistics. Eventually, clearing of XBUS related
statistics should be done here. One that was migrated is the
clearing of 'PCM [TR]X:' numbers currently appearing in
/proc/xpp/XBUS-*/summary (they should be moved too later).
- Shorten the strings representation sync_mode ("SYNC_MODE_AB" -> "AB")
adapted their use in printk and /proc so the text is clear.
- Added a command line parameter xpp.disable_pll_sync to stop all
adjustments command to AB (calculations still continue as usual).
* PRI:
- 4 port support
- set clocking master span via ztcfg, like other zaptel devices.
* FXO:
- Fix false hangups in some countries (voltage fluctuations).
- Some countries send caller-id before first ring.
Added code to handle caller-id PCM pass through according to
a new command line parameter (xpd_fxo.caller_id_style).
- No longer sends an event on zt_open. See
http://bugs.digium.com/view.php?id=12160 .
* Misc:
- Adapt to zaptel-1.4.8 and above ztscan: added fields returend by
new ZT_SPANSTAT_V2 ioctl()
- Document sysfs and waitfor_xpds.
- Miscelaneous optimizations and bugfixes.
- Remove deprecated pcm_tasklet parameter. The rx_tasklet parameter has
replaced it a long time ago.
- Add RX_CMD counter to /proc/xpp/XBUS-*/summary
- Unclutter some of the usb disconnect messages.
- xpp_usb: minor preformance improvements in receive.
Expose the number of pending receive URB's in /proc/xpp/XBUS-*/xpp_usb
Merged revisions 3952 via svnmerge from
http://svn.digium.com/svn/zaptel/branches/1.2
------------------------------------------------------------------------
http://svn.digium.com/view/dahdi?view=rev&revision=3957
Issue History
Date Modified Username Field Change
======================================================================
06-07-08 13:54 svnbot Checkin
06-07-08 13:54 svnbot Note Added: 0088403
======================================================================
More information about the asterisk-bugs
mailing list