[asterisk-bugs] [Zaptel 0011884]: Build fails on Debian 3.1/2.4.27-3-686: static struct member

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11884 
====================================================================== 
Reported By:                tzafrir
Assigned To:                tzafrir
====================================================================== 
Project:                    Zaptel
Issue ID:                   11884
Category:                   General
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Zaptel Version:              SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 3759 
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             01-30-2008 19:18 CST
Last Modified:              06-07-2008 13:51 CDT
====================================================================== 
Summary:                    Build fails on Debian 3.1/2.4.27-3-686: static
struct member
Description: 
On a Debian Sarge system with the package kernel-headers-3-686 installed,
current branches/1.4 SVN, I run:

  make KVERS=2.4.27-3-686

I get the error:

In file included from pciradio.c:57:
zaptel.h: At top level:
zaptel.h:1206: error: syntax error before "static"
zaptel.h:1206: warning: no semicolon at end of struct or union
make[1]: *** [pciradio.o] Error 1


This seems to be cause by the word "static" in the following lines:

struct zt_chardev {
        const char *name;
        __u8 minor;
#ifdef CONFIG_DEVFS_FS
        static devfs_handle_t devfs_handle;
#endif
};

Removing the word "static" makes things build again.

Then I get to:

zaptel-base.c: In function `zt_register_chardev':
zaptel-base.c:7339: error: `mode' undeclared (first use in this function)
zaptel-base.c:7339: error: (Each undeclared identifier is reported only
once
zaptel-base.c:7339: error: for each function it appears in.)
make[2]: *** [zaptel-base.o] Error 1


This code was added in r3635 (rework of transcode device file generation).
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 06-07-08 13:51  
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 3788

_U  team/tzafrir/move/
A   team/tzafrir/move/doc/module-parameters.txt
U   team/tzafrir/move/kernel/wctdm24xxp/base.c
U   team/tzafrir/move/kernel/xpp/utils/zconf/Zaptel/Config/Defaults.pm
U   team/tzafrir/move/kernel/zaptel-base.c
U   team/tzafrir/move/kernel/zaptel.h

------------------------------------------------------------------------
r3788 | tzafrir | 2008-06-07 13:51:01 -0500 (Sat, 07 Jun 2008) | 33 lines

Merged revisions 3767,3775,3779,3783,3785 via svnmerge from 
http://svn.digium.com/svn/zaptel/branches/1.4
(And a manual svn merge in the kernel directory for -r3757:3786)

........
r3767 | tzafrir | 2008-01-31 00:53:33 +0200 (Thu, 31 Jan 2008) | 5 lines

Don't fail zapconf if no config file was found.

Merged revisions 3766 via svnmerge from 
http://svn.digium.com/svn/zaptel/branches/1.2

........
r3775 | mattf | 2008-02-01 00:40:42 +0200 (Fri, 01 Feb 2008) | 1 line

Fix bug so that echo cancellation actually will be disabled
........
r3779 | mattf | 2008-02-01 22:10:28 +0200 (Fri, 01 Feb 2008) | 1 line

Assume if we're disabling echo can that there are no paramters passed
........
r3783 | kpfleming | 2008-02-02 01:32:59 +0200 (Sat, 02 Feb 2008) | 2 lines

add an (incomplete) text document describing module parameters available
in Zaptel modules

........
r3785 | tzafrir | 2008-02-03 05:43:11 +0200 (Sun, 03 Feb 2008) | 3 lines

Fix building in 2.4 w/devfs. Closes issue
http://bugs.digium.com/view.php?id=11884 
(There's still the msleep warning).

........

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=3788 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-07-08 13:51  svnbot         Checkin                                      
06-07-08 13:51  svnbot         Note Added: 0088378                          
======================================================================