[asterisk-bugs] [Zaptel 0011460]: [patch] unused code in zt_q_sig function

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11460 
====================================================================== 
Reported By:                flefoll
Assigned To:                qwell
====================================================================== 
Project:                    Zaptel
Issue ID:                   11460
Category:                   zaptel (the module)
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Zaptel Version:              SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 2810 
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             12-04-2007 07:31 CST
Last Modified:              06-07-2008 13:36 CDT
====================================================================== 
Summary:                    [patch] unused code in zt_q_sig function
Description: 
No bug here : I just saw a strange sequence in zt_q_sig() :

static int printed = 0;
if (printed < 10) {
	printed++;
}

I guess this is a remainder of debugging code.
I propose a patch for SVN trunk to remove it, and de-obfuscate a little
bit zt_q_sig() (I know that C compilers don't care carriage returns, but we
humans do ...).

====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 06-07-08 13:36  
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 3332

_U  betas/zaptel-1.4-te12x-vpm/
U   betas/zaptel-1.4-te12x-vpm/Makefile
U   betas/zaptel-1.4-te12x-vpm/README
U   betas/zaptel-1.4-te12x-vpm/README.hpec
A   betas/zaptel-1.4-te12x-vpm/live_zap
U   betas/zaptel-1.4-te12x-vpm/tor2.c
U   betas/zaptel-1.4-te12x-vpm/torisa.c
U   betas/zaptel-1.4-te12x-vpm/wct1xxp.c
U   betas/zaptel-1.4-te12x-vpm/wct4xxp/base.c
U   betas/zaptel-1.4-te12x-vpm/wctdm.c
U   betas/zaptel-1.4-te12x-vpm/wctdm24xxp/base.c
U   betas/zaptel-1.4-te12x-vpm/wcte11xp.c
U   betas/zaptel-1.4-te12x-vpm/zaptel-base.c
U   betas/zaptel-1.4-te12x-vpm/zaptel.h
U   betas/zaptel-1.4-te12x-vpm/ztscan.c

------------------------------------------------------------------------
r3332 | mspiceland | 2008-06-07 13:36:52 -0500 (Sat, 07 Jun 2008) | 70
lines

Merged revisions 3290-3291,3293-3294,3298,3300,3303,3308,3312,3317,3322
via svnmerge from 
https://origsvn.digium.com/svn/zaptel/branches/1.4

................
r3290 | kpfleming | 2007-12-04 11:41:52 -0600 (Tue, 04 Dec 2007) | 2 lines

fix a bunch of silly bugs and do some code cleanup

................
r3291 | kpfleming | 2007-12-04 11:53:40 -0600 (Tue, 04 Dec 2007) | 2 lines

eliminate the 'general' section from the ztscan output, as it doesn't
contain anything the GUI needs and one user is concerned about the
'totalspans' number having to be kept in sync if the output is edited

................
r3293 | tzafrir | 2007-12-04 12:01:23 -0600 (Tue, 04 Dec 2007) | 2 lines

Fix the case of: make zttool.o zttool

................
r3294 | kpfleming | 2007-12-04 12:13:04 -0600 (Tue, 04 Dec 2007) | 2 lines

the analog card drivers can now mark failed modules as 'broken', and
ztscan can output that information

................
r3298 | dbailey | 2007-12-04 14:56:14 -0600 (Tue, 04 Dec 2007) | 2 lines

Add ioctl call to set hw gain from CLI.  

................
r3300 | qwell | 2007-12-04 15:32:14 -0600 (Tue, 04 Dec 2007) | 4 lines

Remove some code that does...well...nothing.

Closes issue http://bugs.digium.com/view.php?id=11460, patch by flefoll.

................
r3303 | mmichelson | 2007-12-04 16:28:58 -0600 (Tue, 04 Dec 2007) | 4
lines

Moving the ZT_SET_HWGAIN define so that the list maintains the numerical
order
previously established.


................
r3308 | tzafrir | 2007-12-04 17:15:04 -0600 (Tue, 04 Dec 2007) | 2 lines

live_zap - A script to test Zaptel without fully installing it.

................
r3312 | qwell | 2007-12-04 18:15:36 -0600 (Tue, 04 Dec 2007) | 1 line

Fix URL for HPEC README.
................
r3317 | kpfleming | 2007-12-04 21:24:43 -0600 (Tue, 04 Dec 2007) | 2 lines

the previous addition of fields to zt_spaninfo added an 'lbo' field, but
none of the drivers for digital cards actually populate that field... this
is now corrected

................
r3322 | mattf | 2007-12-06 10:41:43 -0600 (Thu, 06 Dec 2007) | 9 lines

Merged revisions 3321 via svnmerge from 
https://origsvn.digium.com/svn/zaptel/branches/1.2

........
r3321 | mattf | 2007-12-06 10:40:22 -0600 (Thu, 06 Dec 2007) | 1 line

Don't mangle old value of this register.  Just set it without the reset
bit set
........

................

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=3332 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-07-08 13:36  svnbot         Checkin                                      
06-07-08 13:36  svnbot         Note Added: 0088343                          
======================================================================