[asterisk-bugs] [Zaptel 0011460]: [patch] unused code in zt_q_sig function

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11460 
====================================================================== 
Reported By:                flefoll
Assigned To:                qwell
====================================================================== 
Project:                    Zaptel
Issue ID:                   11460
Category:                   zaptel (the module)
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Zaptel Version:              SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 2810 
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             12-04-2007 07:31 CST
Last Modified:              06-07-2008 13:36 CDT
====================================================================== 
Summary:                    [patch] unused code in zt_q_sig function
Description: 
No bug here : I just saw a strange sequence in zt_q_sig() :

static int printed = 0;
if (printed < 10) {
	printed++;
}

I guess this is a remainder of debugging code.
I propose a patch for SVN trunk to remove it, and de-obfuscate a little
bit zt_q_sig() (I know that C compilers don't care carriage returns, but we
humans do ...).

====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 06-07-08 13:36  
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 3311

_U  team/tzafrir/sysfs/
U   team/tzafrir/sysfs/README
A   team/tzafrir/sysfs/live_zap
U   team/tzafrir/sysfs/zaptel-base.c
U   team/tzafrir/sysfs/zaptel.h

------------------------------------------------------------------------
r3311 | tzafrir | 2008-06-07 13:36:16 -0500 (Sat, 07 Jun 2008) | 31 lines

Merge live_zap and other stuff:

Merged revisions 3298,3300,3303,3308 via svnmerge from 
http://svn.digium.com/svn/zaptel/branches/1.4

........
r3298 | dbailey | 2007-12-04 22:56:14 +0200 (Tue, 04 Dec 2007) | 2 lines

Add ioctl call to set hw gain from CLI.  

........
r3300 | qwell | 2007-12-04 23:32:14 +0200 (Tue, 04 Dec 2007) | 4 lines

Remove some code that does...well...nothing.

Closes issue http://bugs.digium.com/view.php?id=11460, patch by flefoll.

........
r3303 | mmichelson | 2007-12-05 00:28:58 +0200 (Wed, 05 Dec 2007) | 4
lines

Moving the ZT_SET_HWGAIN define so that the list maintains the numerical
order
previously established.


........
r3308 | tzafrir | 2007-12-05 01:15:04 +0200 (Wed, 05 Dec 2007) | 2 lines

live_zap - A script to test Zaptel without fully installing it.

........

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=3311 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-07-08 13:36  svnbot         Checkin                                      
06-07-08 13:36  svnbot         Note Added: 0088340                          
======================================================================