[asterisk-bugs] [Zaptel 0010505]: fxotune.c:827: error: size of array '__open_missing_mode' is negative

Sat Jun 7 13:16:21 CDT 2008

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10505 
====================================================================== 
Reported By:                thimm
Assigned To:                tzafrir
====================================================================== 
Project:                    Zaptel
Issue ID:                   10505
Category:                   Utilities
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Zaptel Version:             1.4.4  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             08-20-2007 21:12 CDT
Last Modified:              06-07-2008 13:16 CDT
====================================================================== 
Summary:                    fxotune.c:827: error: size of array
'__open_missing_mode' is negative
Description: 
from open(2)
       mode must be specified when O_CREAT is in the  flags,  and  is 
ignored
       otherwise.

Recent glibc like the one to be shipped with F8 changed open usage in two
ways: first it needs to be treated as a macro (as defined in POSIX) and
secondly the mode is mandatory for O_CREAT (it was random if missing until
now)

====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 06-07-08 13:16  
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 2944

_U  be/branches/B.2/
U   be/branches/B.2/Makefile
U   be/branches/B.2/Makefile.kernel26
U   be/branches/B.2/README
U   be/branches/B.2/build_tools/install_prereq
U   be/branches/B.2/fxotune.c
_U  be/branches/B.2/wctdm24xxp/
U   be/branches/B.2/wctdm24xxp/GpakApi.c
U   be/branches/B.2/wctdm24xxp/GpakCust.c
U   be/branches/B.2/wctdm24xxp/GpakCust.h
U   be/branches/B.2/wctdm24xxp/base.c
U   be/branches/B.2/wctdm24xxp/wctdm24xxp.h
U   be/branches/B.2/wcte12xp.c
_U  be/branches/B.2/xpp/
U   be/branches/B.2/xpp/.version
U   be/branches/B.2/xpp/ChangeLog
U   be/branches/B.2/xpp/Makefile
U   be/branches/B.2/xpp/README.Astribank
U   be/branches/B.2/xpp/card_bri.c
U   be/branches/B.2/xpp/card_fxo.c
U   be/branches/B.2/xpp/card_fxs.c
U   be/branches/B.2/xpp/card_global.c
U   be/branches/B.2/xpp/card_global.h
U   be/branches/B.2/xpp/firmwares/FPGA_1141.hex
U   be/branches/B.2/xpp/firmwares/FPGA_1151.hex
U   be/branches/B.2/xpp/firmwares/FPGA_FXS.hex
U   be/branches/B.2/xpp/utils/Makefile
A   be/branches/B.2/xpp/utils/astribank_hook
U   be/branches/B.2/xpp/utils/genzaptelconf
U   be/branches/B.2/xpp/utils/xpp.rules
U   be/branches/B.2/xpp/utils/xpp_fxloader
U   be/branches/B.2/xpp/utils/zconf/Zaptel/Config/Defaults.pm
U   be/branches/B.2/xpp/utils/zconf/Zaptel/Hardware/PCI.pm
U   be/branches/B.2/xpp/xbus-core.c
U   be/branches/B.2/xpp/xbus-core.h
A   be/branches/B.2/xpp/xbus-sysfs.c
U   be/branches/B.2/xpp/xpd.h
U   be/branches/B.2/xpp/xpp_usb.c
U   be/branches/B.2/xpp/xpp_zap.c
U   be/branches/B.2/xpp/xpp_zap.h
U   be/branches/B.2/xpp/xproto.c
U   be/branches/B.2/xpp/xproto.h
U   be/branches/B.2/xpp/zap_debug.h
U   be/branches/B.2/zaptel-base.c
U   be/branches/B.2/zaptel.init
U   be/branches/B.2/zaptel.sysconfig
U   be/branches/B.2/zconfig.h

------------------------------------------------------------------------
r2944 | jlyons | 2008-06-07 13:16:18 -0500 (Sat, 07 Jun 2008) | 186 lines

Merged revisions 2781-2783,2785-2788,2790-2926 via svnmerge from 
https://origsvn.digium.com/svn/zaptel/branches/1.2

........
  r2781 | mattf | 2007-07-27 14:02:28 -0500 (Fri, 27 Jul 2007) | 1 line

  Minor message removal
........
  r2786 | mattf | 2007-07-27 14:32:25 -0500 (Fri, 27 Jul 2007) | 1 line

  Quick fix for could not fill input buffer errors
........
  r2796 | tzafrir | 2007-07-28 18:49:55 -0500 (Sat, 28 Jul 2007) | 2 lines

  Ignore generated files on the new wctdm24xxp dir.
........
  r2808 | qwell | 2007-08-01 15:21:04 -0500 (Wed, 01 Aug 2007) | 2 lines

  Per Matt Fredrickson, we don't want to use GFP_KERNEL while holding a
spinlock.
........
  r2811 | tzafrir | 2007-08-01 16:33:56 -0500 (Wed, 01 Aug 2007) | 12
lines

  xpp.r4415:
    * Show Astribank 6+2 as 6/2 channels and not 8/8 channels.
      - Added as a "subtype" to the device type (r4391).
    * Fixed a panic in BRI span shutdown method (r4393).
    * Changes to debug macros.
    * Add proper sysfs support (r4406)
      - A bus on whuch all of the Astribanks reside.
      - Replaces useless sysfs code that existed in the module.
      - Currently used to set the sync source automatically at device
        adition / removal.
    * BRI: We do need the T1 timer in NT. If it gets into G2 state
(rr4407).
........
  r2818 | tzafrir | 2007-08-05 06:55:21 -0500 (Sun, 05 Aug 2007) | 2 lines

  Extra Zaptel PCI IDs (from Philipp Kempgen). From Xorcom r4466.
........
  r2829 | mattf | 2007-08-10 16:54:56 -0500 (Fri, 10 Aug 2007) | 1 line

  Make sure we permit MRM commands
........
  r2832 | tzafrir | 2007-08-14 14:56:40 -0500 (Tue, 14 Aug 2007) | 7 lines

  Merging a few small changes Xorcom:
  * Marked with no. 4416, to note that major changes after 4415 were
    note merged yet.
  * Demote the messages about PCM in non-PCM from notice to debug (r4501).
  * Fix sample BRI zapata.conf: NT instead of TE (r4498).
  * Disable FXS hardware DTMF detection by default (r4492).
........
  r2836 | tzafrir | 2007-08-14 18:37:10 -0500 (Tue, 14 Aug 2007) | 2 lines

  Fix building on older CentOS 4 and Trixbox.
........
  r2838 | tzafrir | 2007-08-15 08:36:10 -0500 (Wed, 15 Aug 2007) | 5 lines

  * Allow setting the echo canceller from the Makefile or the environment
    (needed for overriding the default EC in Debian m-a builds)
  * Allow specifiying extra modules in the make command line:
    MODULES_EXTRA.
........
  r2840 | tzafrir | 2007-08-15 10:27:13 -0500 (Wed, 15 Aug 2007) | 7 lines

  Fixing installation targets:
  - programs/install-programs - userspace utilities.
  - libs/install-libs - libtonezone
  - modules/install-modules - kernel stuff

  Those can be used independently.
........
  r2841 | mattf | 2007-08-15 12:01:15 -0500 (Wed, 15 Aug 2007) | 1 line

  Make sure we use the new URL for ftp.digium.com
........
  r2844 | mattf | 2007-08-15 13:08:42 -0500 (Wed, 15 Aug 2007) | 1 line

  Make sure that the URL is REALLY up to date
........
  r2850 | tzafrir | 2007-08-16 08:57:27 -0500 (Thu, 16 Aug 2007) | 3 lines

  * Add a rule for generating xpp/README.html (not used by default).
  * Ignore it, and clean it and README.html .
........
  r2852 | mattf | 2007-08-16 12:01:18 -0500 (Thu, 16 Aug 2007) | 1 line

  Make sure the gain adjustment is only done if the VPM100M is present
........
  r2857 | mattf | 2007-08-16 15:02:58 -0500 (Thu, 16 Aug 2007) | 1 line

  Fix for when voicebus based cards stop taking interrupts on some systems
........
  r2860 | tzafrir | 2007-08-16 15:08:58 -0500 (Thu, 16 Aug 2007) | 11
lines

  xpp rev. 4515:
  * BRI improvement: an 'nt_keepalive' parameter to xpd_bri forces
    a BRI_NT to retry a connection indefinitely (this is our default).
    When false it revert to the behaviour in changeset:4415 ("Bezeq like")
  * Improvement in DBG macros. The print_dbg parameter is now set of
    flags to debug. They are defined in zap_debug.h
  * Don't use Astribanks connected to USB1 interfaces
    Unless the user set the option usb1=1 for xpp_usb (r4504).
  * And some more documentation...
  * Include some of our variables in the default zaptel sample file.
........
  r2861 | mattf | 2007-08-16 15:10:03 -0500 (Thu, 16 Aug 2007) | 1 line

  Remove some unused variables from compilation
........
  r2864 | mattf | 2007-08-16 15:47:46 -0500 (Thu, 16 Aug 2007) | 1 line

  Make sure we enable MRM
........
  r2868 | tzafrir | 2007-08-17 01:53:53 -0500 (Fri, 17 Aug 2007) | 5 lines

  * Make sure every userspace tool is built with CFLAGS and LDFLAGS.
  * Search for newt.h in INCLUDE_DIR.
  * Build makefw and gendigits with HOSTCC .
  * Don't build makefw in the 'programs' target.
........
  r2871 | tzafrir | 2007-08-17 04:18:13 -0500 (Fri, 17 Aug 2007) | 2 lines

  -l should come after LDFLAGS.
........
  r2873 | tzafrir | 2007-08-17 07:41:47 -0500 (Fri, 17 Aug 2007) | 8 lines

  * Re-introduce the target install-include .
  * programs and install-programs are now for all of userspace.
    Added the target 'utils'  for what 'programs' used to be.
  * Document this.
  * Document some other variations on 'make' and 'make install'.
  * Improve documentation of /proc/zaptel .
  * Ignoring some more utilities.
........
  r2878 | tzafrir | 2007-08-17 11:16:23 -0500 (Fri, 17 Aug 2007) | 2 lines

  Fix building extra modules in subdirectories.
........
  r2880 | tzafrir | 2007-08-17 13:10:23 -0500 (Fri, 17 Aug 2007) | 2 lines

  install_prereq: Don't install packages twice.
........
  r2903 | tzafrir | 2007-08-18 15:21:10 -0500 (Sat, 18 Aug 2007) | 5 lines

  * Fix makefile targets to match documentation.
  * Fix dependencies of install-utils.
  * Rename the generated xpp/README.html to xpp/README.Astribank.html to
    provide a unique basename among docs (helps debian packaging).
........
  r2904 | tzafrir | 2007-08-18 16:13:19 -0500 (Sat, 18 Aug 2007) | 2 lines

  Zaptel 1.2 doesn't use autoconf just yet :-(
........
  r2906 | tzafrir | 2007-08-19 07:08:33 -0500 (Sun, 19 Aug 2007) | 3 lines

  Fix README.Astribank with asciidoc 8.2.2: make "underlining" more
  strict. (xpp r4519)
........
  r2910 | tzafrir | 2007-08-20 08:24:24 -0500 (Mon, 20 Aug 2007) | 5 lines

  * Set maximal zaptel udev timeout to 20 seconds.
  * Allow overriding it from cwrcconfconfig file (and explain how).

  (From trunk r2909 - got accidentally commited there first).
........
  r2914 | tzafrir | 2007-08-21 03:00:25 -0500 (Tue, 21 Aug 2007) | 6 lines

  * Add an explicit mode to the callto open (the default one that is used
    anyway).
  * Clarify error message.

  Closes http://bugs.digium.com/view.php?id=10505 on Zaptel 1.2.
........
  r2919 | tzafrir | 2007-08-21 11:19:56 -0500 (Tue, 21 Aug 2007) | 2 lines

  Fix building on kernel 2.6.23rc1, from Axel Thimm (xpp r4523).
........
  r2923 | mattf | 2007-08-21 13:40:23 -0500 (Tue, 21 Aug 2007) | 1 line

  Allow wctdm24xxp to compile on a 2.4 based kernel
........
  r2926 | mattf | 2007-08-21 13:55:44 -0500 (Tue, 21 Aug 2007) | 1 line

  Make sure 1.2 wctdm24xxp builds on 2.4 kernels
........

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=2944 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-07-08 13:16  svnbot         Note Added: 0088318                          
======================================================================