[asterisk-bugs] [Zaptel 0007191]: [patch] ZT_ONHOOKTRANSFER will not set the slic state if reversepolarity is set

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=7191 
====================================================================== 
Reported By:                Thomas Andrews
Assigned To:                
====================================================================== 
Project:                    Zaptel
Issue ID:                   7191
Category:                   wctdm
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Zaptel Version:              1.2.10 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        Yes 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             05-21-2006 11:57 CDT
Last Modified:              06-07-2008 12:58 CDT
====================================================================== 
Summary:                    [patch] ZT_ONHOOKTRANSFER will not set the slic
state if reversepolarity is set
Description: 
In release 1.2 in wctdm.c on line 1739 I think there is a mistake. It looks
like this currently:

 if (wc->mod[chan->chanpos - 1].fxs.lasttxhook == 0x1) {

but I think it should take account of the polarity like this:

 if ((wc->mod[chan->chanpos - 1].fxs.lasttxhook == 0x1) ||
     (wc->mod[chan->chanpos - 1].fxs.lasttxhook == 0x5)) {

====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 06-07-08 12:58  
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 2685

_U  trunk/
U   trunk/wctdm.c

------------------------------------------------------------------------
r2685 | qwell | 2008-06-07 12:58:31 -0500 (Sat, 07 Jun 2008) | 22 lines

Merged revisions 2684 via svnmerge from 
https://origsvn.digium.com/svn/zaptel/branches/1.4

Closes issue http://bugs.digium.com/view.php?id=7191

................
r2684 | qwell | 2007-07-03 13:58:24 -0500 (Tue, 03 Jul 2007) | 12 lines

Merged revisions 2683 via svnmerge from 
https://origsvn.digium.com/svn/zaptel/branches/1.2

........
r2683 | qwell | 2007-07-03 13:57:42 -0500 (Tue, 03 Jul 2007) | 4 lines

Fix a potential issue with the reversepolarity module option in wctdm.

Issue 7191, patch by Thomas Andrews.

........

................

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=2685 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-07-08 12:58  svnbot         Checkin                                      
06-07-08 12:58  svnbot         Note Added: 0088302                          
======================================================================