[asterisk-bugs] [Zaptel 0008458]: [patch] remove defined but not used code from zaptel.c and torisa.c

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=8458 
====================================================================== 
Reported By:                tzafrir
Assigned To:                file
====================================================================== 
Project:                    Zaptel
Issue ID:                   8458
Category:                   Core/General
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     closed
Zaptel Version:              SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 1665 
Disclaimer on File?:        Yes 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             11-30-2006 14:58 CST
Last Modified:              06-07-2008 12:16 CDT
====================================================================== 
Summary:                    [patch] remove defined but not used code from
zaptel.c and torisa.c
Description: 
Building zaptel gives you, among others, the warnings:

  CC [M]  /home/tzafrir/Proj/Asterisk/zaptel/torisa.o
/home/tzafrir/Proj/Asterisk/zaptel/torisa.c:1145: warning: ?set_tor_base?
defined but not used
  CC [M]  /home/tzafrir/Proj/Asterisk/zaptel/zaptel.o
/home/tzafrir/Proj/Asterisk/zaptel/zaptel.c:226: warning: ?fcstab? defined
but not used

The attached patch simply removes the function set_tor_base from torisa.c
and the array fcstab from zaptel.c . Both are static and unreferenced
elsewhere. An exact copy of fcstab seems to reside in both hflcstress.c and
in hdlctest.c .

If they are not to be removed, please document clearly in the code what
purpose they serve.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0008792 SVN rev 1806 fail on compile
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 06-07-08 12:16  
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 1802

U   trunk/torisa.c
U   trunk/zaptel.c

------------------------------------------------------------------------
r1802 | file | 2008-06-07 12:16:00 -0500 (Sat, 07 Jun 2008) | 2 lines

Remove old and unused declarations. If these do serve a purpose we can
throw them back in. (issue http://bugs.digium.com/view.php?id=8458 reported by
tzafrir)

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=1802 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-07-08 12:16  svnbot         Checkin                                      
06-07-08 12:16  svnbot         Note Added: 0088222                          
======================================================================