[asterisk-bugs] [Zaptel 0007203]: [patch] fxotune doesn't close files when in debug mode
noreply at bugs.digium.com
noreply at bugs.digium.com
Sat Jun 7 11:50:35 CDT 2008
A NOTE has been added to this issue.
======================================================================
http://bugs.digium.com/view.php?id=7203
======================================================================
Reported By: tzafrir
Assigned To: russell
======================================================================
Project: Zaptel
Issue ID: 7203
Category: Utilities
Reproducibility: always
Severity: minor
Priority: normal
Status: closed
Zaptel Version: SVN
SVN Branch (only for SVN checkouts, not tarball releases): trunk
SVN Revision (number only!): 1077
Disclaimer on File?: Yes
Request Review:
Resolution: fixed
Fixed in Version:
======================================================================
Date Submitted: 05-22-2006 09:24 CDT
Last Modified: 06-07-2008 11:50 CDT
======================================================================
Summary: [patch] fxotune doesn't close files when in debug
mode
Description:
fopen without fclose may work, if it's not in a loop.
The attached patch does not remove all the possible leakage sources. It
just makes the contents of the debug file partially useful (of the last
useful channel)
======================================================================
----------------------------------------------------------------------
svnbot - 06-07-08 11:50
----------------------------------------------------------------------
Repository: dahdi
Revision: 1371
_U be/B.1-2/
U be/B.1-2/Makefile
D be/B.1-2/OCT6114-128D.ima
D be/B.1-2/fw2h.c
U be/B.1-2/fxotune.c
D be/B.1-2/include/
D be/B.1-2/octapi_bt0_private.h
D be/B.1-2/octapi_llman_private.h
D be/B.1-2/octvpm.h
D be/B.1-2/vpm450m.c
D be/B.1-2/vpm450m.h
A be/B.1-2/wct4xxp/
D be/B.1-2/wct4xxp/Kbuild
A be/B.1-2/wct4xxp/Kbuild
D be/B.1-2/wct4xxp/Makefile
A be/B.1-2/wct4xxp/Makefile
D be/B.1-2/wct4xxp/OCT6114-128D.ima
A be/B.1-2/wct4xxp/OCT6114-128D.ima
D be/B.1-2/wct4xxp/base.c
A be/B.1-2/wct4xxp/base.c
D be/B.1-2/wct4xxp/fw2h.c
A be/B.1-2/wct4xxp/fw2h.c
D be/B.1-2/wct4xxp/vpm450m.c
A be/B.1-2/wct4xxp/vpm450m.c
D be/B.1-2/wct4xxp/vpm450m.h
A be/B.1-2/wct4xxp/vpm450m.h
D be/B.1-2/wct4xxp/wct4xxp-diag.c
A be/B.1-2/wct4xxp/wct4xxp-diag.c
D be/B.1-2/wct4xxp/wct4xxp.h
A be/B.1-2/wct4xxp/wct4xxp.h
D be/B.1-2/wct4xxp-diag.c
D be/B.1-2/wct4xxp.h
D be/B.1-2/wct4xxp_base.c
U be/B.1-2/wcte11xp.c
U be/B.1-2/zaptel.c
U be/B.1-2/zaptel.init
------------------------------------------------------------------------
r1371 | jlyons | 2008-06-07 11:49:40 -0500 (Sat, 07 Jun 2008) | 87 lines
Merged revisions
1262,1298,1300,1304,1306,1311,1313,1315,1317,1326-1327,1359,1362-1363,1368
via svnmerge from
https://origsvn.digium.com/svn/zaptel/branches/1.2
........
r1262 | kpfleming | 2006-08-08 17:22:24 -0500 (Tue, 08 Aug 2006) | 2 lines
update Octasic API headers (but not code yet) to PR43, and use version
with GPL licenses instead of proprietary licenses
........
r1298 | russell | 2006-08-13 19:54:28 -0500 (Sun, 13 Aug 2006) | 3 lines
the change from $(PWD) to $(SUBDIRS) breaks the build on some systems. So,
just
use them both ... (issue http://bugs.digium.com/view.php?id=7720)
........
r1300 | russell | 2006-08-13 20:44:59 -0500 (Sun, 13 Aug 2006) | 2 lines
add a note that ENABLE_TASKLETS is not implemented in wct4xxp (issue
http://bugs.digium.com/view.php?id=7688)
........
r1304 | russell | 2006-08-13 23:07:00 -0500 (Sun, 13 Aug 2006) | 3 lines
fix potential deadlock found by kernel's lock checker
(issue http://bugs.digium.com/view.php?id=7620, reported by smurfix, fixed by
Corydon)
........
r1306 | kpfleming | 2006-08-14 15:40:55 -0500 (Mon, 14 Aug 2006) | 2 lines
revert this change until a version that compiles on 2.4 kernels and older
2.6 kernels is made available and tested
........
r1311 | russell | 2006-08-15 16:30:49 -0500 (Tue, 15 Aug 2006) | 3 lines
fix passing a 'w' to wait when using pulse dialing
(issue http://bugs.digium.com/view.php?id=7738, hanabana)
........
r1313 | russell | 2006-08-15 16:43:26 -0500 (Tue, 15 Aug 2006) | 4 lines
fix erroneous check to see if PWD was set before setting it in the Zaptel
Makefile. It should always be set. If not, it breaks the build when
using
recursive calls to make. (issue http://bugs.digium.com/view.php?id=7733,
tzafrir)
........
r1315 | russell | 2006-08-15 17:06:13 -0500 (Tue, 15 Aug 2006) | 4 lines
Ensure that fopen() is only called once for the debug output file to
prevent
excessive file descriptor leakage when this function is called many times
in
a loop. (issue http://bugs.digium.com/view.php?id=7203)
........
r1317 | tilghman | 2006-08-15 20:36:34 -0500 (Tue, 15 Aug 2006) | 2 lines
Bug 7624 - Debian lacks /var/lock/subsys
........
r1326 | mattf | 2006-08-18 15:20:08 -0500 (Fri, 18 Aug 2006) | 2 lines
Add b410p support into 1.2 Makefile.
........
r1327 | kpfleming | 2006-08-18 21:27:49 -0500 (Fri, 18 Aug 2006) | 2 lines
don't report the VPM servicing more spans than the card actually has
........
r1359 | kpfleming | 2006-08-26 21:02:42 -0500 (Sat, 26 Aug 2006) | 2 lines
merge in new, cleaner Octasic API integration
........
r1362 | kpfleming | 2006-08-26 21:20:56 -0500 (Sat, 26 Aug 2006) | 2 lines
it would probably help if we actually linked the Octasic API objects into
the wct4xxp module :-)
........
r1363 | kpfleming | 2006-08-26 21:27:23 -0500 (Sat, 26 Aug 2006) | 2 lines
ok... finally, this actually does build correctly for 2.4 kernels
........
r1368 | file | 2006-08-27 17:58:06 -0500 (Sun, 27 Aug 2006) | 2 lines
Copy the firmware from the new location
........
------------------------------------------------------------------------
http://svn.digium.com/view/dahdi?view=rev&revision=1371
Issue History
Date Modified Username Field Change
======================================================================
06-07-08 11:50 svnbot Checkin
06-07-08 11:50 svnbot Note Added: 0088169
======================================================================
More information about the asterisk-bugs
mailing list