[asterisk-bugs] [Asterisk 0007733]: 'make -C path/to/zaptel linux26' fails: incorrect PWD

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=7733 
====================================================================== 
Reported By:                tzafrir
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   7733
Category:                   Core/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           I did not set the version :( 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             08-14-2006 18:16 CDT
Last Modified:              06-07-2008 11:44 CDT
====================================================================== 
Summary:                    'make -C path/to/zaptel linux26' fails: incorrect
PWD
Description: 
before zaptel 1.2.7 the zaptel Makefile had:

PWD=$(shell pwd)

This seems useless at first. It is useless if the make operation is run
from the current working directory. However it makes the value of PWD be
set ccorrectly when make is called recuresively.

PWD is used when calling the kernel 2.6 kbuild system: 
make -C path/to/kernel/source SUBDIRS=$(PWD) modules

In zaptel 1.2.7 the line above now has:
ifeq ($(PWD),)
PWD=$(shell pwd)
endif

By default there is a value for PWD (from the shell) and thus PWD will not
be set to the zaptel source directory and the kernel building process will
attempt to build modules in the wrong directory.
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 06-07-08 11:44  
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 1314

_U  trunk/
U   trunk/Makefile

------------------------------------------------------------------------
r1314 | russell | 2008-06-07 11:44:32 -0500 (Sat, 07 Jun 2008) | 12 lines

Merged revisions 1313 via svnmerge from 
https://origsvn.digium.com/svn/zaptel/branches/1.2

........
r1313 | russell | 2006-08-15 17:43:26 -0400 (Tue, 15 Aug 2006) | 4 lines

fix erroneous check to see if PWD was set before setting it in the Zaptel
Makefile.  It should always be set.  If not, it breaks the build when
using
recursive calls to make. (issue http://bugs.digium.com/view.php?id=7733,
tzafrir)

........

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=1314 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-07-08 11:44  svnbot         Checkin                                      
06-07-08 11:44  svnbot         Note Added: 0088149                          
======================================================================