[asterisk-bugs] [Asterisk 0003323]: [patch] DYNFS is not correctly set

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=3323 
====================================================================== 
Reported By:                zigman
Assigned To:                markster
====================================================================== 
Project:                    Asterisk
Issue ID:                   3323
Category:                   Core/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           I did not set the version :( 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             01-11-2005 20:58 CST
Last Modified:              06-07-2008 10:47 CDT
====================================================================== 
Summary:                    [patch] DYNFS is not correctly set
Description: 
i was rebuilding my asterisk today and was supprised, that the zaptel
Makefile created my /dev/zap* devices. I use udevd so it shouldn't be
created.
so i checked the makefile and indeed. it should.
but my DYNFS var was emtpy, so they got created.
to make a long story short.
here is some output

root at winxp:~# cat Makefile
all:
        @echo $(shell ps ax | grep -v grep | grep init)
        @echo $(shell ps ax | grep -v grep | grep udevd)
root at winxp:~# LC_ALL=C make
1 ? S 0:01 init [3]
/bin/sh: s: No such file or directory
make: *** [all] Error 1

why did the first work and the second not?

root at winxp:~# LC_ALL=C make -n
echo     1 ?        S      0:01 init [3]
echo   865 ?        S<s    0:00 udevd

there is is.. it piping a <s

there are 2 proper fixes
the one i like more is

from zaptel-1.0.3 Makefile
ifeq (${BUILDVER},linux24)
#We only support DEVFS in linux 2.4 kernels, since its considered obsolete
post 2.4
DYNFS=$(ps ax | grep -v grep | grep devfsd)
endif
ifeq (${BUILDVER},linux26)
#Tests for newer linux-2.6 udev support
DYNFS=$(ps ax | grep -v grep | grep udevd)
endif

which is just plain wrong. (at least gave me empty strings here)

either replace ps ax with  "ps axo comm" to only diplay command names. or
what i did with the patch is to sed the output of ps

====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 06-07-08 10:47  
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 561

U   branches/v1-0/Makefile

------------------------------------------------------------------------
r561 | russell | 2008-06-07 10:47:41 -0500 (Sat, 07 Jun 2008) | 2 lines

set DYNFS correctly (bug http://bugs.digium.com/view.php?id=3323)

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=561 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-07-08 10:47  svnbot         Note Added: 0087999                          
======================================================================