[asterisk-bugs] [Asterisk 0010668]: Incomplete CDR lock

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10668 
====================================================================== 
Reported By:                arkadia
Assigned To:                murf
====================================================================== 
Project:                    Asterisk
Issue ID:                   10668
Category:                   CDR/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.4.11  
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             09-07-2007 08:26 CDT
Last Modified:              06-06-2008 14:26 CDT
====================================================================== 
Summary:                    Incomplete CDR lock
Description: 
This is all about the meaning of AST_CDR_FLAG_LOCKED flag for CDR. 
I assume if CDR has this flag set then it wont be updated anymore by any
ast_cdr_ functions except cases when we force such update. ast_cdr_reset()
is example of function which allows to update locked CDRs if special flag
is given.

Based on this assumption I prepared the patch with such changes:

  ast_cdr_setvar() - not allowed to touch locked CDRs. I don't see any
cases when we need to change locked CDRs too. Not touching locked CDRs is
helpfull when ForkCDR being used and every new CDR may have different
custom variables.

  ast_cdr_answer() - don't change status of locked CDRs. That might be
helpfull when we have a chain of CDRs for one incoming call for which we
perform several tries to make outgoing call. Every outgoing attempt may
finish with its own completion code. And if the final attempt is 'answered'
then we have only one CDR with 'answered' status. All other will keep
connection error codes which is very helpful for error monitoring.

 ast_cdr_end() - don't change locked CDRs by the same reason as
ast_cdr_answer()

As there will be no changes in CDR after lock, app_forkcdr.c should be
updated to end original locked CDR.
Also it'll be great to make optional cdr reset in this application, but
thats a theme for another patch.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0012726 ForkCDR application fails to set duration
====================================================================== 

---------------------------------------------------------------------- 
 murf - 06-06-08 14:26  
---------------------------------------------------------------------- 
As far as I can tell, the change I made to ast_cdr_noanswer was just the
insertion of the two lines. It, like ast_cdr_busy(), etc, did not
previously obey any kind of LOCKED flag.

As to locking end time, do you see this as a viable and useful thing?
CDR's with no end times are pretty useless, and will generate warnings.
You'll need some way to remove the lock before the channel hangs up... very
messy. No, let's leave that one be.

And, setvar has opts last and recur, so it has 3 ways to set chained
cdrs:
  1. just the cdr in question (no opt)(no respect for locked or unlocked).

  2. just the last cdr in the chain. (l option)
  3. All CDR's in the chain (r option) (whether locked or not).

So, are you proposing/wishing this:
     Add 'u' option to CDR() func, to set !LOCKED cdr's only? (useless 
     with 'l' option, as last CDR in chain will never be LOCKED; with 'r'
     option, it will only set unlocked CDR's; with no other opts, will
     only set the current CDR if it is not locked). And, for CDR reading,
     'u' will return the value from the first unlocked CDR.

Is this really necessary, tho? Rather than add a lot of opts with subtle
affects on the outcome, will the r/l opts be sufficient? Why not? 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-06-08 14:26  murf           Note Added: 0087908                          
======================================================================