[asterisk-bugs] [Asterisk 0010668]: Incomplete CDR lock

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10668 
====================================================================== 
Reported By:                arkadia
Assigned To:                murf
====================================================================== 
Project:                    Asterisk
Issue ID:                   10668
Category:                   CDR/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.11  
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             09-07-2007 08:26 CDT
Last Modified:              06-02-2008 09:46 CDT
====================================================================== 
Summary:                    Incomplete CDR lock
Description: 
This is all about the meaning of AST_CDR_FLAG_LOCKED flag for CDR. 
I assume if CDR has this flag set then it wont be updated anymore by any
ast_cdr_ functions except cases when we force such update. ast_cdr_reset()
is example of function which allows to update locked CDRs if special flag
is given.

Based on this assumption I prepared the patch with such changes:

  ast_cdr_setvar() - not allowed to touch locked CDRs. I don't see any
cases when we need to change locked CDRs too. Not touching locked CDRs is
helpfull when ForkCDR being used and every new CDR may have different
custom variables.

  ast_cdr_answer() - don't change status of locked CDRs. That might be
helpfull when we have a chain of CDRs for one incoming call for which we
perform several tries to make outgoing call. Every outgoing attempt may
finish with its own completion code. And if the final attempt is 'answered'
then we have only one CDR with 'answered' status. All other will keep
connection error codes which is very helpful for error monitoring.

 ast_cdr_end() - don't change locked CDRs by the same reason as
ast_cdr_answer()

As there will be no changes in CDR after lock, app_forkcdr.c should be
updated to end original locked CDR.
Also it'll be great to make optional cdr reset in this application, but
thats a theme for another patch.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0012726 ForkCDR application fails to set duration
====================================================================== 

---------------------------------------------------------------------- 
 murf - 06-02-08 09:46  
---------------------------------------------------------------------- 
Arkadia--

Several of the routines that act on CDR's, do so on the entire list,
obeying
the LOCKED flag. The 3 did not, and at least for setting the end time, I
can understand why it would ignore the LOCK... So that all forked CDR's
would be ended at the same time. The original assumptions you mentioned in
this bug report about how LOCK would be interpreted in the CDR code seemed
reasonable, but were proved to be wrong. There are subtle effects on the
CDR system of playing with these flags, and any changes will have to prove
they won't muck things up.

As to not adding the flags to 1.4, well, I've heavily tested them, and
they aren't hurting anyone by being available in 1.4. But, I know of at
least one case, where they are helping to solve problems with situations
that weren't considered when ForkCDR was written. So, I'd really rather
leave them available in 1.4, for the sake of the few who might find them
lifesavers.

You are trying to do something via ForkCDR, I perceive, that involves
these LOCKS (or lack of them) getting in the way. What is it you are trying
to do, maybe there's another way to accomplish your goal? 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-02-08 09:46  murf           Note Added: 0087652                          
======================================================================