[asterisk-bugs] [Asterisk 0013203]: [patch] [branch] [appdocsxml] Some fixes, and trying to start an entry point for patches to this branch
Asterisk Bug Tracker
noreply at bugs.digium.com
Thu Jul 31 10:25:46 CDT 2008
A NOTE has been added to this issue.
======================================================================
http://bugs.digium.com/view.php?id=13203
======================================================================
Reported By: eliel
Assigned To: bkruse
======================================================================
Project: Asterisk
Issue ID: 13203
Category: General
Reproducibility: have not tried
Severity: feature
Priority: normal
Status: assigned
Asterisk Version: SVN
SVN Branch (only for SVN checkouts, not tarball releases): trunk
SVN Revision (number only!): 134757
Disclaimer on File?: N/A
Request Review:
======================================================================
Date Submitted: 2008-07-30 23:50 CDT
Last Modified: 2008-07-31 10:25 CDT
======================================================================
Summary: [patch] [branch] [appdocsxml] Some fixes, and trying
to start an entry point for patches to this branch
Description:
I have many questions about the ideas about the implementation, what I have
done in this patch is a code review with minor fixes, and I was trying to
understand the idea behind the code, Please don't close this issue if the
patch is not ready, so I can continue submitting patches for this branch.
======================================================================
----------------------------------------------------------------------
(0090902) bkruse (manager) - 2008-07-31 10:25
http://bugs.digium.com/view.php?id=13203#c90902
----------------------------------------------------------------------
Great, being committed now.
I will request you get direct access to the branch, this is good work.
Only comments: on the big for loop, I cut that out of menuselect. I do
like your method much better, as it IS cleaner. Did you do any functional
testing to see if the basics were still in operation?
Thanks!
-bk
Issue History
Date Modified Username Field Change
======================================================================
2008-07-31 10:25 bkruse Note Added: 0090902
======================================================================
More information about the asterisk-bugs
mailing list