[asterisk-bugs] [Asterisk 0013203]: [patch] [branch] [appdocsxml] Some fixes, and trying to start an entry point for patches to this branch

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13203 
====================================================================== 
Reported By:                eliel
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13203
Category:                   General
Reproducibility:            have not tried
Severity:                   feature
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 134757 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-07-30 23:50 CDT
Last Modified:              2008-07-30 23:59 CDT
====================================================================== 
Summary:                    [patch] [branch] [appdocsxml] Some fixes, and trying
to start an entry point for patches to this branch
Description: 
I have many questions about the ideas about the implementation, what I have
done in this patch is a code review with minor fixes, and I was trying to
understand the idea behind the code, Please don't close this issue if the
patch is not ready, so I can continue submitting patches for this branch.
====================================================================== 

---------------------------------------------------------------------- 
 (0090892) eliel (manager) - 2008-07-30 23:59
 http://bugs.digium.com/view.php?id=13203#c90892 
---------------------------------------------------------------------- 
Fixes:
    - Memory was being overwritten when creating the path string, you
didn't count the '/'.
    - It it not necessary to fclose(NULL), when fopen() failed to open
'xmldoc'.
    - ast_config_destroy() when not using anymore the allocated config
structure.

Changes:
    - The Makefile should install doc/core-*.xml (and not only
core-en.xml) to /var/lib/asterisk (if more languages are created their will
be put there).
    - When opening the documentation file, open core-<language>.xml.
    - language was setted as en_US, es_SP, etc, so, the main filename was
changed to core-en_US.xml.    
    - finish adding 'XML_DOCUMENTATION' preprocesor checks to avoid
compiling code that refers to xml_documentation.
    - Minor syntax changes:
         Instead of using a looooong for(init;cond;inc) with a biiig
'init' and a biiig 'inc' use:
         init;
         while(cond) {  ; inc;}
         making code more readable.

I hope this could start a discussion to clarify some ideas... 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-07-30 23:59 eliel          Note Added: 0090892                          
======================================================================