[asterisk-bugs] [Asterisk 0013152]: [patch] extending the support of ATTENDED_TRANSFER_COMPLETE_SOUND for more channel types

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13152 
====================================================================== 
Reported By:                caio1982
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13152
Category:                   Core/General
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 133438 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-07-24 14:29 CDT
Last Modified:              2008-07-30 09:09 CDT
====================================================================== 
Summary:                    [patch] extending the support of
ATTENDED_TRANSFER_COMPLETE_SOUND for more channel types
Description: 
As of today only SIP channels supports the channel variable
ATTENDED_TRANSFER_COMPLETE_SOUND, which indicates a sound file to be played
upon transfered calls. This patch try to make IAX, Skinny and DAHDI
channels capable of that since they all support 'setvar' (tested with SIP
to make sure at least this one hasn't been broken).

The peer who made the transfer by default hears the pbx-transfer sound and
the third peer receiving the call hears 'xfersound' from features.conf,
while the transfered party does not hear anything. By using this variable
now the transfered party will hear the sound file from it too.
====================================================================== 

---------------------------------------------------------------------- 
 (0090835) caio1982 (reporter) - 2008-07-30 09:09
 http://bugs.digium.com/view.php?id=13152#c90835 
---------------------------------------------------------------------- 
Is there any design or code problem with the attached patch or it's ok as
is? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-07-30 09:09 caio1982       Note Added: 0090835                          
======================================================================