[asterisk-bugs] [Asterisk 0010396]: [patch] Restructure transmit_callstate function and calls to transmit_

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10396 
====================================================================== 
Reported By:                wedhorn
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   10396
Category:                   Channels/chan_skinny
Reproducibility:            N/A
Severity:                   tweak
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.0-beta4 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 78336 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2007-08-07 06:50 CDT
Last Modified:              2008-07-29 19:40 CDT
====================================================================== 
Summary:                    [patch] Restructure transmit_callstate function and
calls to transmit_
Description: 
Broke up transmit_callstate to it's individual components so now all
transmit_ functions build a single packet (except transmit_response which
actually sends the packet out).

Additionally, modified all calls to transmit_ functions to pass device
rather than session as the state of session is unknown and basically
requires testing before every call.

This is step 1 of a multiple step process in getting transfer into trunk.
====================================================================== 

---------------------------------------------------------------------- 
 (0090823) wedhorn (reporter) - 2008-07-29 19:40
 http://bugs.digium.com/view.php?id=10396#c90823 
---------------------------------------------------------------------- 
There were basically two parts to this patch.

The first was to pass device (rather than session) to the transmit_ stuff.
The reason for this was that session can be dropped and we would need to
test if their is a session before really doing anything (such as the
logging bug mentioned elsewhere).

The second was to restructure the transmit_ functions into singular
transmits (some of the transmit_ functions sent multiple packets to the
devices and where this wasn't appropriate the full transmit was coded in
line).

I think the first issue still exists but the second one was predominantly
incorporated into the transfer revision
(http://svn.digium.com/view/asterisk?view=rev&revision=125096), although
there may be further adjustments. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-07-29 19:40 wedhorn        Note Added: 0090823                          
======================================================================