[asterisk-bugs] [Asterisk 0012475]: [patch] message about number of new and old messages not properly conjugated in Russian

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12475 
====================================================================== 
Reported By:                chappell
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   12475
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.4.19 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             04-18-2008 09:35 CDT
Last Modified:              07-23-2008 11:45 CDT
====================================================================== 
Summary:                    [patch] message about number of new and old messages
not properly conjugated in Russian
Description: 
This is an old patch which we have been using for over a year.  Without it
the introductory message about how many voicemail messages are in the new
and old boxes is garbled.  The problems include dropt works, bad grammar,
and wrong counts.  As best I remember the patch fixes these problems:

* removed bad exception code for the Russian word for "one" in the neuter
singular
* due to confusion one of the counts of messages was wrong
* fixed conjugation of the adjectives meaning "old" and "new"

If necessary, I can go back and study the old code in order to accurately
describe exactly how it garbles the message.



====================================================================== 

---------------------------------------------------------------------- 
 chappell - 07-23-08 11:45  
---------------------------------------------------------------------- 
I am working on a new version of this patch based on your comments.  I
think I have the spacing problems fixed, I have moved the applications into
their own file.  I still have to figure out the currently practice for
parsing.

As for point 4, I think there is a misunderstanding due to the fact that
the current patch enables this code only for Russian.  Since my new
voicemail intro function works in a much more language neutral way, there
is no reason why it could not replace the default function.  The next
version of my patch will make this clearer.  Furthur, counted_noun_en()
does in fact correctly pluralize English nouns within the scope of this
problem.  Appending nothing would break it.  Again, this will be clearer in
the next version of the patch. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-23-08 11:45  chappell       Note Added: 0090610                          
======================================================================