[asterisk-bugs] [Zaptel 0013108]: [patch] Uninstalling modules will fail when installing to the subtree

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13108 
====================================================================== 
Reported By:                Romik
Assigned To:                
====================================================================== 
Project:                    Zaptel
Issue ID:                   13108
Category:                   zaptel (the module)
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     new
Zaptel Version:             1.4.11 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             07-18-2008 10:42 CDT
Last Modified:              07-21-2008 05:08 CDT
====================================================================== 
Summary:                    [patch] Uninstalling modules will fail when
installing to the subtree
Description: 
Modules uninstall script ./build_tools/uninstall-modules will partially
fail when installing to the subtree DESTDIR=/somepath/ .
------------------------------------------
for mod in $MODULES; do
        BASE=`basename $mod`
        for file in `cat $KERNEL_MODULES_DIR/modules.dep | cut -d : -f 1 |
grep "$BASE$"`; do
                if [ -e "$file" ]; then
                        #echo "Deleting $file."
                        rm -f $file
                fi
        done
done
------------------------------------------
`cat $KERNEL_MODULES_DIR/modules.dep` fill fail with 
cat: /subtree-path/lib/modules/kernel-version/modules.dep: No such file or
directory
====================================================================== 

---------------------------------------------------------------------- 
 tzafrir - 07-21-08 05:08  
---------------------------------------------------------------------- 
The patch fixes the symptom. But I think that the issue here is that the
uninstall-modules script is not robust. What if you install to a DESTDIR
and it actually had older versions?

A casual look at the uninstall script also shows that it uses files in
/tmp in an insecure way. temporary files should be created with mktemp(1). 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-21-08 05:08  tzafrir        Note Added: 0090514                          
======================================================================