[asterisk-bugs] [DAHDI 0011504]: [patch] printk-s without priority in zaptel

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11504 
====================================================================== 
Reported By:                tzafrir
Assigned To:                sruffell
====================================================================== 
Project:                    DAHDI
Issue ID:                   11504
Category:                   General
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             12-10-2007 11:30 CST
Last Modified:              07-17-2008 14:17 CDT
====================================================================== 
Summary:                    [patch] printk-s without priority in zaptel
Description: 
There are still quite a few places in zaptel where printk is used without a
priority string (KERN_DEBUG, KERN_ERR, etc.).

To see them:

  grep -w printk *.[ch] */*.[ch] | egrep -v
'KERN_(DEBUG|INFO|NOTICE|WARNING|ERR)' | grep -v '\.mod\.c'

Use 'grep -wl' instead of 'grep -w' to get a list of files.

====================================================================== 

---------------------------------------------------------------------- 
 bbryant - 07-17-08 14:17  
---------------------------------------------------------------------- 
sruffell, that'd be great. I didn't want to commit anything before someone
had a chance to review it.

As for the priority in debug_printk: except for a missing newline on line
261 of wcte12xp/base.c there don't seem to be any places that use it with a
priority or a multiline statement which was why my motivation was for
putting it there instead. If you want, I can change the debug_printk
statements to add KERN_DEBUG so it can be used for multiline statements. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-17-08 14:17  bbryant        Note Added: 0090416                          
======================================================================