[asterisk-bugs] [Asterisk 0013074]: [PATCH] duplicate code for setting LSPI

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13074 
====================================================================== 
Reported By:                markwilkinson
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13074
Category:                   Channels/chan_dahdi
Reproducibility:            N/A
Severity:                   tweak
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 130945 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             07-15-2008 03:38 CDT
Last Modified:              07-17-2008 14:05 CDT
====================================================================== 
Summary:                    [PATCH] duplicate code for setting LSPI
Description: 
After talking with Matthew and Alan via E-mail, I noticed in chan_dahdi.c
there are 2 near identical calls to set the SS7 LSPI parameters dependant
on channel variables SS7_RLT_ON and SS7_LSPI_IDENT

code begins around line 2455 in chan_dahdi.c
====================================================================== 

---------------------------------------------------------------------- 
 alanmcmillan - 07-17-08 14:05  
---------------------------------------------------------------------- 
Mark, Matt- I have a concern about combining the SS7_LSPI_IDENT parm and
the SS7_RLT_ON parm.. The SS7_LSPI_IDENT parm is an optional parameter in
and IAM and I do not know if it being set means that we are going to want
to use RLT process. It just so happens that when it is set to the values I
hard coded in CHAN_DAHDI(on the BLEG IAM) it causes the NORTEL DMS-250 to
send back the CALLREFERNCE values needed to identify the leg of the call so
the FAR can being sent on the ALEG bridges successfully to the correct BLEG
and drops the ASTERISK out of the call. 

Also my SEND_FAR is not complete. The current version of RLT in asterisk
only allows for a NON-ANSWERED call to be successfully RLT’d off the
ASTERISK.  The SEND_FAR was being developed for ANSWERED RLT types. 

So as of today the dialplan needs to be as follows to allow RLT on the
NORTEL to work properly.   

exten => _X.,1,Set(_SS7_LSPI_IDENT=206555)
exten => _X.,n,Set(_SS7_RLT_ON=YES)
exten => _X.,n,Dial(ZAP/g1/8005551212,30)
exten => _X.,n,Hangup(16);

I think some of Marks patch should be added allowing the SS7_LSPI_IDENT to
be fully set from the dialplan. But using that to trigger the RLT process
needs to be researched a little more.

If mark want to develop further the RLT code that also cool.  Either way
its nice to have others looking into and giving feedback..

Alan 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-17-08 14:05  alanmcmillan   Note Added: 0090413                          
======================================================================