[asterisk-bugs] [DAHDI 0011504]: printk-s without priority in zaptel

noreply at bugs.digium.com noreply at bugs.digium.com
Thu Jul 17 13:49:00 CDT 2008


A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11504 
====================================================================== 
Reported By:                tzafrir
Assigned To:                sruffell
====================================================================== 
Project:                    DAHDI
Issue ID:                   11504
Category:                   General
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             12-10-2007 11:30 CST
Last Modified:              07-17-2008 13:48 CDT
====================================================================== 
Summary:                    printk-s without priority in zaptel
Description: 
There are still quite a few places in zaptel where printk is used without a
priority string (KERN_DEBUG, KERN_ERR, etc.).

To see them:

  grep -w printk *.[ch] */*.[ch] | egrep -v
'KERN_(DEBUG|INFO|NOTICE|WARNING|ERR)' | grep -v '\.mod\.c'

Use 'grep -wl' instead of 'grep -w' to get a list of files.

====================================================================== 

---------------------------------------------------------------------- 
 sruffell - 07-17-08 13:48  
---------------------------------------------------------------------- 
Thanks for the patch Brett.  I believe I looked through all the changes,
and with the exception of line 31 in dahdi_echocan_hpec (the kernel log
level in that case should be passed as part of the format string from the
caller), the other places look good to me.  At least they'll all have a
level...

If you want me to commit this, I'll do it one module at a time (so I can
recheck before I commit each one). 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-17-08 13:48  sruffell       Note Added: 0090410                          
======================================================================




More information about the asterisk-bugs mailing list