[asterisk-bugs] [Asterisk 0013084]: Once enabled the recording/monitoring will not disable

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13084 
====================================================================== 
Reported By:                elbriga
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13084
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Asterisk Version:           1.4.21 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             07-15-2008 15:55 CDT
Last Modified:              07-16-2008 12:52 CDT
====================================================================== 
Summary:                    Once enabled the recording/monitoring will not
disable
Description: 
The field "monitor-format" is used to control weather or not to record the
queue calls. When I start my asterisk (tested on the last version,
1.4.21-1) with this field empty (in pgsql realtime) it wil not record the
queue call. OK.
Then I set the monitor-format field to 'wav49', make a call, and it will
record the call with the MixMonitor App. OK.
Now it's the problem! When I reset the field (empty string value) and make
the same call, the MixMonitor App still starts and record the call, and
will keep recording, no matter the value of the monitor-format field, until
I unload/load the app_queue module or restart the Asterisk.
====================================================================== 

---------------------------------------------------------------------- 
 elbriga - 07-16-08 12:52  
---------------------------------------------------------------------- 
I solved my problem here by changing the line that controls the monitoring
(app_queue.c:2884, right below the "/* Begin Monitoring */" line):

it was:
if (qe->parent->monfmt && *qe->parent->monfmt) {

changed to:
if (qe->parent->monfmt && strlen(qe->parent->monfmt) > 2) {

Since the three options for this param are: "gsm|wav|wav49"
It will only record if the param is at least 3 chars long. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-16-08 12:52  elbriga        Note Added: 0090350                          
======================================================================