[asterisk-bugs] [Asterisk 0012960]: ast_merge_contexts_and_delete() does not merge switches and includes properly

[noreply at bugs.digium.com]

The following issue has been RESOLVED. 
====================================================================== 
http://bugs.digium.com/view.php?id=12960 
====================================================================== 
Reported By:                mnicholson
Assigned To:                murf
====================================================================== 
Project:                    Asterisk
Issue ID:                   12960
Category:                   Core/PBX
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     resolved
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 126574 
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             06-30-2008 14:14 CDT
Last Modified:              07-15-2008 18:28 CDT
====================================================================== 
Summary:                    ast_merge_contexts_and_delete() does not merge
switches and includes properly
Description: 
When using pbx_config and pbx_ael at the same time, if  context exists in
both pbx_config and pbx_ael, the includes and switches from that context
are not properly merged.  Which ever module was loaded/reloaded last takes
precedence.

This only seems to be a problem if two modules are sharing a context.
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 07-15-08 18:28  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 131129

U   trunk/main/pbx.c

------------------------------------------------------------------------
r131129 | murf | 2008-07-15 18:28:31 -0500 (Tue, 15 Jul 2008) | 21 lines


(closes issue http://bugs.digium.com/view.php?id=12960)
Reported by: mnicholson

Spent most of the day on this bug, and the
solution was so simple. Just had to find and
understand the problem.

The problem was, that the routine to copy
the existing switches, includes, and ignorepats
from the old context to the new one, wasn't
getting called when the context is already 
existent. (In other words, if AEL is adding
a new context to the mix, they get copied,
but if pbx_config already defined a context,
then the copy wasn't happening. This made
no sense, so I moved the call to copy the 
includes & etc, no matter the case.



------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=131129 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-15-08 18:28  svnbot         Note Added: 0090322                          
07-15-08 18:28  svnbot         Status                   assigned => resolved
07-15-08 18:28  svnbot         Resolution               reopened => fixed   
======================================================================