[asterisk-bugs] [Asterisk 0013080]: [patch] in ast_cdr_setapp if (!app) app = NULL; if (!data) data = NULL; is redondant with following uses of S_OR

[noreply at bugs.digium.com]

The following issue has been ASSIGNED. 
====================================================================== 
http://bugs.digium.com/view.php?id=13080 
====================================================================== 
Reported By:                gknispel_proformatique
Assigned To:                mvanbaak
====================================================================== 
Project:                    Asterisk
Issue ID:                   13080
Category:                   CDR/General
Reproducibility:            N/A
Severity:                   trivial
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 130978 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             07-15-2008 12:23 CDT
Last Modified:              07-15-2008 12:39 CDT
====================================================================== 
Summary:                    [patch] in ast_cdr_setapp  if (!app) app = NULL; if
(!data) data = NULL; is redondant with following uses of S_OR
Description: 
One does not need to do a :

if (!app)
  app = "";

when the only following use of app is through S_OR(app, "")

Same thing for data.
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 07-15-08 12:39  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 131012

U   branches/1.4/main/cdr.c

------------------------------------------------------------------------
r131012 | mvanbaak | 2008-07-15 12:39:24 -0500 (Tue, 15 Jul 2008) | 7
lines

remove 4 lines of redundant code.

(closes issue http://bugs.digium.com/view.php?id=13080)
Reported by: gknispel_proformatique
Patches:
      trunk_ast_cdr_setapp.patch uploaded by gknispel (license 261)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=131012 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-15-08 12:39  svnbot         Note Added: 0090296                          
07-15-08 12:39  svnbot         Status                   new => assigned     
07-15-08 12:39  svnbot         Assigned To               => mvanbaak        
======================================================================