[asterisk-bugs] [Asterisk 0013062]: [patch] doc/tex/Makefile uses non-portable -i flag for sed

noreply at bugs.digium.com noreply at bugs.digium.com
Sun Jul 13 18:06:34 CDT 2008


A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13062 
====================================================================== 
Reported By:                mvanbaak
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13062
Category:                   Documentation
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             07-12-2008 09:06 CDT
Last Modified:              07-13-2008 18:06 CDT
====================================================================== 
Summary:                    [patch] doc/tex/Makefile uses non-portable -i flag
for sed
Description: 
While trying to generate the HTML docs from the tex source I ran into the
problem that the sed calls in doc/tex/Makefile use the -i flag.
This flag is not present on every system.

Besides that, the sed calls are useless because it tries to replace
ASTERISKVERSION and that string does not appear in any tex file.

This patch simply removes these calls and the surrounding cp/mv calls to
restore the original asterisk.tex

Now it works great on both my linux and OpenBSD boxen.
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 07-13-08 18:06  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 130578

U   trunk/build_tools/prep_tarball
U   trunk/doc/tex/Makefile
U   trunk/res/Makefile

------------------------------------------------------------------------
r130578 | mvanbaak | 2008-07-13 18:06:29 -0500 (Sun, 13 Jul 2008) | 15
lines

Make all sed calls Posix sed compatible.
To make sure nobody commits script-modified files we first make a backup
of asterisk.tex, run the script, generate the pdf and / or html,
and put the original asterisk.tex back.
This will guard us for the stuff that happened before that someone
committed 
a locally modified asterisk.tex, with changes done by this script.

(closes issue http://bugs.digium.com/view.php?id=13062)
Reported by: mvanbaak
Patches:
      sed_without-i-v3.diff uploaded by mvanbaak (license 7)
Tested by: mvanbaak

Feedback from Corydon. Thanks for taking the time to go through this.

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=130578 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-13-08 18:06  svnbot         Note Added: 0090179                          
======================================================================




More information about the asterisk-bugs mailing list