[asterisk-bugs] [Asterisk 0013058]: [patch] ast_str api janitor

noreply at bugs.digium.com noreply at bugs.digium.com
Thu Jul 10 15:52:34 CDT 2008


A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13058 
====================================================================== 
Reported By:                pputman
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13058
Category:                   Applications/app_meetme
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 129732 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             07-10-2008 15:11 CDT
Last Modified:              07-10-2008 15:52 CDT
====================================================================== 
Summary:                    [patch] ast_str api janitor
Description: 
Changes certain strings to ast_str to replace multiple library calls
====================================================================== 

---------------------------------------------------------------------- 
 bbryant - 07-10-08 15:52  
---------------------------------------------------------------------- 
pputman, a few suggestions on your patch:

- When you create an ast_str* you must call ast_str_create() or
ast_str_alloca() to initialize it. 
  (Using ast_str_alloca() is easier than adding a call to ast_free() at
the end of a function.)

- Use ast_str_set instead of ast_copy_string. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-10-08 15:52  bbryant        Note Added: 0090047                          
======================================================================




More information about the asterisk-bugs mailing list