[asterisk-bugs] [Asterisk 0012475]: [patch] message about number of new and old messages not properly conjugated in Russian

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12475 
====================================================================== 
Reported By:                chappell
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   12475
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.4.19 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             04-18-2008 09:35 CDT
Last Modified:              07-07-2008 18:10 CDT
====================================================================== 
Summary:                    [patch] message about number of new and old messages
not properly conjugated in Russian
Description: 
This is an old patch which we have been using for over a year.  Without it
the introductory message about how many voicemail messages are in the new
and old boxes is garbled.  The problems include dropt works, bad grammar,
and wrong counts.  As best I remember the patch fixes these problems:

* removed bad exception code for the Russian word for "one" in the neuter
singular
* due to confusion one of the counts of messages was wrong
* fixed conjugation of the adjectives meaning "old" and "new"

If necessary, I can go back and study the old code in order to accurately
describe exactly how it garbles the message.



====================================================================== 

---------------------------------------------------------------------- 
 Corydon76 - 07-07-08 18:10  
---------------------------------------------------------------------- 
This patch is also not in compliance with the coding guidelines.  This
needs to be fixed before the patch can be considered for commitment. 
Specifically:

1) The spacing around if statements and opening braces is incorrect.  You
are also not using braces on every conditional, as is now part of the
guidelines.

2) You are using strsep to parse arguments, where you should be using the
standard argument parsing macros.  Also, you are using the wrong argument
delimiters for trunk (this would not be an issue if you used the standard
parsing macros).

3) Your applications should be placed into their own source file, not
within main/pbx.c.  Also, I'm not sure why you're mapping these API from
say.c as function pointers.  As there are no competing implementations, you
do not need these API calls to be function pointers.

4) Please do not call your function "universal", as it is not descriptive.
 If you want to use vm_intro_ru for both Russian and Ukrainian, that's
fine.  Also, calling the default function "counted_noun_en" is not
acceptable, as people will expect that it should correctly pluralize terms
in English.  Instead, don't create such a function at all, but merely omit
appending anything (e.g. ending = "").  Ditto for "counted_adjective_en".

5) You're using tiny static buffers all over this patch for values for
which you don't control the length.  It would be better to alloca() the
correct length, when necessary. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-07-08 18:10  Corydon76      Note Added: 0089867                          
======================================================================