[asterisk-bugs] [Asterisk 0013002]: [patch] janitor task to substitute in-line sizeof() for array_len to calculate the length of arrays

noreply at bugs.digium.com noreply at bugs.digium.com
Sun Jul 6 14:56:26 CDT 2008


A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13002 
====================================================================== 
Reported By:                caio1982
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13002
Category:                   General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 128490 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             07-06-2008 14:22 CDT
Last Modified:              07-06-2008 14:56 CDT
====================================================================== 
Summary:                    [patch] janitor task to substitute in-line sizeof()
for array_len to calculate the length of arrays
Description: 
Just noticed this new dirty janitor job in doc/janitor-projects.txt. Maybe
there are still some missing statements out there but these were the easy
ones to find and I also took advantage of the cleanup and add some if
braces.
====================================================================== 

---------------------------------------------------------------------- 
 mvanbaak - 07-06-08 14:56  
---------------------------------------------------------------------- 
great job.
It's funny to see you added a lot of braces to chan_iax2.c but forgot to
do so for some of the for statements you actually altered to use ARRAY_LEN
And some places where you have:
for (.... ARRAY_LEN....) {
  if ()
    statement()


Just something I noticed. And because you mentioned the braces thing in
the report ... 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-06-08 14:56  mvanbaak       Note Added: 0089809                          
======================================================================




More information about the asterisk-bugs mailing list