[asterisk-bugs] [Asterisk 0012773]: [patch] Agent doesn't propagate device state changes from underlying device.

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12773 
====================================================================== 
Reported By:                davidw
Assigned To:                Corydon76
====================================================================== 
Project:                    Asterisk
Issue ID:                   12773
Category:                   Channels/chan_agent
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.4.20.1 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             06-02-2008 11:30 CDT
Last Modified:              07-04-2008 06:36 CDT
====================================================================== 
Summary:                    [patch] Agent doesn't propagate device state changes
from underlying device.
Description: 
Given a SIP phone logged in with AgentLogin, and monitored with qualify, if
you remove the power on the phone (or, presumably, unplug it from the
network) Asterisk detects that the phone has become unavailable, but the
agent continues to receive calls, resulting in callers going into a black
hole.

Ideally, I believe that the agent should detect the state change on the
underlying device and change its own state to logged off, and therefore
generate a state change to CHANUNVAIL.  This would result in correct
hinting for the agent's state.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0012771 Bogus <member> is still 'Not in U...
====================================================================== 

---------------------------------------------------------------------- 
 davidw - 07-04-08 06:36  
---------------------------------------------------------------------- 
Potentially anywhere that p->chan gets set to NULL, inherited status should
get reset.  (Some of these will be redundant, as they relate to callback
logins, but I think that the bit near line 1577 is already only applied for
callback.)

In this case, I think the specific problem is the one near line 2242 in
__login_exec.

Resetting inherited state immediately after that reset of p->chan seems to
remove the symptom, here. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-04-08 06:36  davidw         Note Added: 0089733                          
======================================================================