[asterisk-bugs] [Asterisk 0012942]: [patch] Dialog state NOTIFY for hold uses badly formed XML

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12942 
====================================================================== 
Reported By:                gowen72
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   12942
Category:                   Channels/chan_sip/Interoperability
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 126116 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             06-27-2008 19:09 CDT
Last Modified:              07-01-2008 02:42 CDT
====================================================================== 
Summary:                    [patch] Dialog state NOTIFY for hold uses badly
formed XML
Description: 
For DIALOG_INFO_XML subscriptions, asterisk generates malformed XML for the
hold state NOTIFY events.

The problem is that the XML tag added to indicate the hold state (the
sip.rendering attribute) is not being terminated.  Since there is no value
for this tag, it should be self-terminated, in the same way you are
supposed to use "<hr/>" for a horizontal ruler in HTML.

Here is what is being sent:

  <param pname="+sip.rendering" pvalue="no">

But it shoud be:

  <param pname="+sip.rendering" pvalue="no"/>


Note the "/" character prior the closing ">".


====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 07-01-08 02:42  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 126735

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r126735 | oej | 2008-07-01 02:42:00 -0500 (Tue, 01 Jul 2008) | 7 lines

Fix bad XML for hold notification.
Reported by: gowen72
Patches: 
      hold.patch uploaded by gowen72 (license 432)
(closes issue http://bugs.digium.com/view.php?id=12942)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=126735 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-01-08 02:42  svnbot         Checkin                                      
07-01-08 02:42  svnbot         Note Added: 0089457                          
======================================================================