[asterisk-bugs] [Asterisk 0011886]: function REALTIME() broken

noreply at bugs.digium.com noreply at bugs.digium.com
Thu Jan 31 09:33:21 CST 2008


The following issue has been ASSIGNED. 
====================================================================== 
http://bugs.digium.com/view.php?id=11886 
====================================================================== 
Reported By:                sergee
Assigned To:                file
====================================================================== 
Project:                    Asterisk
Issue ID:                   11886
Category:                   Functions/func_realtime
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 101373 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             01-31-2008 06:04 CST
Last Modified:              01-31-2008 09:33 CST
====================================================================== 
Summary:                    function REALTIME() broken
Description: 
this error in code occured due to CODING-GUIDELINES. I believe that all
blocks should be nested in braces , even if the block contains only 1
operator.

IMHO

if (a) {
 printf("a");
}

is much better then 

if (a)
 printf("b");


1st variant will automaticly exclude problems like this one.
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 01-31-08 09:33  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 101393

U   trunk/funcs/func_realtime.c

------------------------------------------------------------------------
r101393 | file | 2008-01-31 09:33:19 -0600 (Thu, 31 Jan 2008) | 6 lines

Add missing braces.
(closes issue http://bugs.digium.com/view.php?id=11886)
Reported by: sergee
Patches:
      func_realtime_fix-r101392.diff uploaded by sergee (license 138)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=101393 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
01-31-08 09:33  svnbot         Note Added: 0081496                          
01-31-08 09:33  svnbot         Status                   new => assigned     
01-31-08 09:33  svnbot         Assigned To               => file            
======================================================================




More information about the asterisk-bugs mailing list