[asterisk-bugs] [Asterisk 0011754]: app_controlplayback: Remove the default skip keys * and #

[noreply at bugs.digium.com]

The following issue has been ASSIGNED. 
====================================================================== 
http://bugs.digium.com/view.php?id=11754 
====================================================================== 
Reported By:                johan
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   11754
Category:                   Applications/app_controlplayback
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 98558 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             01-12-2008 17:19 CST
Last Modified:              01-30-2008 13:00 CST
====================================================================== 
Summary:                    app_controlplayback: Remove the default skip keys *
and #
Description: 
In patch 0011753 the issue with the (badly) elected skip keys came up. My
sugestion was to drop them. Jason Parker suggested that this discussion
should be handled separatley.

In mail to the Asterisk dev mailinglist I raised the question if we could
remove these defaults sience they seems to be strange (voip-info.org: Note
that as the *** key is on the left and the *#* button is on the right of a 
telephone keypad, it may make more sense to swap the default buttons: use
*** for rewind and *#* for forward.)

Except for Jason, nobody replied. 

Jason's idea is quoted below, for reference, I still vote to remove the
defaults.
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 01-30-08 13:00  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 101296

U   trunk/apps/app_controlplayback.c

------------------------------------------------------------------------
r101296 | qwell | 2008-01-30 13:00:24 -0600 (Wed, 30 Jan 2008) | 10 lines

Allow disabling the default ffwd/rewind keys in the ControlPlayback
application.
This is done in a backward compat way.
If the "default" key for ffwd/rew is used for another option (such as
stop), the "default" is removed.

(closes issue http://bugs.digium.com/view.php?id=11754)
Reported by: johan
Patches:
      app_controlplayback.c.option3.patch uploaded by johan (license 334)
Tested by: johan, qwell

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=101296 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
01-30-08 13:00  svnbot         Note Added: 0081452                          
01-30-08 13:00  svnbot         Status                   new => assigned     
01-30-08 13:00  svnbot         Assigned To               => qwell           
======================================================================