[asterisk-bugs] [Asterisk 0011874]: [patch] VoicemailUsersList AMI action does not always send VoicemailUserEntryComplete event

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11874 
====================================================================== 
Reported By:                srt
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   11874
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.6.0-beta1 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 101126 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             01-29-2008 19:44 CST
Last Modified:              01-30-2008 10:28 CST
====================================================================== 
Summary:                    [patch] VoicemailUsersList AMI action does not
always send VoicemailUserEntryComplete event
Description: 
All manager actions that send their response as a series of events send a
corresponding "complete" event on success.
VoicemailUsersList only sends the comlete event if there are more than 0
voicemail users. In Asterisk-Java this results in a timeout as the library
does not know if events will still follow or not.
The attached patch always sends the complete event. Additionally it
removes a superfluous "\r\n" in the ack message.
The patch is against trunk but the problem is also present in 1.6.0-beta1
====================================================================== 

---------------------------------------------------------------------- 
 srt - 01-30-08 10:28  
---------------------------------------------------------------------- 
The problem is that there is no general way to decide whether events will
follow or not as they very across the different actions that generate
responses.
Examples:
Status sends "Channel status will follow"
CoreShowChannels sends "Channels will follow"
MeetmeList sends "Meetme user list will follow"
All these actions send a corresponding XXXComplete event if a success
response is returned even if the there are no active channels, meetme
rooms, etc.

So if there are no voicemail users we could either send an error response
that can be parsed (without checking for a specific message text) or send a
success message followed by a VoicemailUserEntryComplete event. As it is
not really an error if there are no voicemail users and the other actions
already behave this way I prefer the second option. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
01-30-08 10:28  srt            Note Added: 0081438                          
======================================================================