[asterisk-bugs] [Asterisk 0011754]: app_controlplayback: Remove the default skip keys * and #
noreply at bugs.digium.com
noreply at bugs.digium.com
Wed Jan 30 04:42:32 CST 2008
A NOTE has been added to this issue.
======================================================================
http://bugs.digium.com/view.php?id=11754
======================================================================
Reported By: johan
Assigned To:
======================================================================
Project: Asterisk
Issue ID: 11754
Category: Applications/app_controlplayback
Reproducibility: always
Severity: feature
Priority: normal
Status: new
Asterisk Version: SVN
SVN Branch (only for SVN checkouts, not tarball releases): trunk
SVN Revision (number only!): 98558
Disclaimer on File?: N/A
Request Review:
======================================================================
Date Submitted: 01-12-2008 17:19 CST
Last Modified: 01-30-2008 04:42 CST
======================================================================
Summary: app_controlplayback: Remove the default skip keys *
and #
Description:
In patch 0011753 the issue with the (badly) elected skip keys came up. My
sugestion was to drop them. Jason Parker suggested that this discussion
should be handled separatley.
In mail to the Asterisk dev mailinglist I raised the question if we could
remove these defaults sience they seems to be strange (voip-info.org: Note
that as the *** key is on the left and the *#* button is on the right of a
telephone keypad, it may make more sense to swap the default buttons: use
*** for rewind and *#* for forward.)
Except for Jason, nobody replied.
Jason's idea is quoted below, for reference, I still vote to remove the
defaults.
======================================================================
----------------------------------------------------------------------
johan - 01-30-08 04:42
----------------------------------------------------------------------
I've implemented your option 3.
I guess there is no need to add a note to UPGRADE then, as
ControlPlayback() should behave as before. Maybe you would like to mention
it in CHANGES together with the feature in 0011377 (as in the patch)
I constructed this dialplan to test it:
context catchall {
_X. => {
Answer();
Wait(1);
ControlPlayback(tt-monkeys,3000);
ControlPlayback(tt-monkeys);
ControlPlayback(tt-monkeys,,,,1234567890*#);
ControlPlayback(tt-monkeys,,,,1234567890,*,#);
ControlPlayback(tt-monkeys,,,,1234567890,,#);
ControlPlayback(tt-monkeys,,,,1234567890,,*);
ControlPlayback(tt-monkeys,3000,,,*,,1);
ControlPlayback(tt-monkeys,3000,,,,#,1);
Hangup();
}
And the output (together with some debug statements that isn't included in
the path:
-- Executing [0303350971 at catchall:1] Answer("SIP/0303350971-08229408",
"") in new stack
-- Executing [0303350971 at catchall:2] Wait("SIP/0303350971-08229408",
"1") in new stack
-- Executing [0303350971 at catchall:3]
ControlPlayback("SIP/0303350971-08229408", "tt-monkeys,3000") in new stack
[Jan 30 11:25:22] WARNING[13022]: app_controlplayback.c:133
controlplayback_exec: args.fwd = #
[Jan 30 11:25:22] WARNING[13022]: app_controlplayback.c:143
controlplayback_exec: args.rew = *
-- <SIP/0303350971-08229408> Playing 'tt-monkeys.gsm' (language 'en')
-- Executing [0303350971 at catchall:4]
ControlPlayback("SIP/0303350971-08229408", "tt-monkeys") in new stack
[Jan 30 11:25:38] WARNING[13022]: app_controlplayback.c:133
controlplayback_exec: args.fwd = #
[Jan 30 11:25:38] WARNING[13022]: app_controlplayback.c:143
controlplayback_exec: args.rew = *
-- <SIP/0303350971-08229408> Playing 'tt-monkeys.gsm' (language 'en')
-- Executing [0303350971 at catchall:5]
ControlPlayback("SIP/0303350971-08229408", "tt-monkeys,,,,1234567890*#") in
new stack
[Jan 30 11:25:55] WARNING[13022]: app_controlplayback.c:136
controlplayback_exec: args.fwd = NULL
[Jan 30 11:25:55] WARNING[13022]: app_controlplayback.c:146
controlplayback_exec: args.rew = NULL
-- <SIP/0303350971-08229408> Playing 'tt-monkeys.gsm' (language 'en')
-- Executing [0303350971 at catchall:6]
ControlPlayback("SIP/0303350971-08229408", "tt-monkeys,,,,1234567890,*,#")
in new stack
[Jan 30 11:26:11] WARNING[13022]: app_controlplayback.c:136
controlplayback_exec: args.fwd = NULL
[Jan 30 11:26:11] WARNING[13022]: app_controlplayback.c:146
controlplayback_exec: args.rew = NULL
-- <SIP/0303350971-08229408> Playing 'tt-monkeys.gsm' (language 'en')
-- Executing [0303350971 at catchall:7]
ControlPlayback("SIP/0303350971-08229408", "tt-monkeys,,,,1234567890,,#")
in new stack
[Jan 30 11:26:27] WARNING[13022]: app_controlplayback.c:136
controlplayback_exec: args.fwd = NULL
[Jan 30 11:26:27] WARNING[13022]: app_controlplayback.c:143
controlplayback_exec: args.rew = *
-- <SIP/0303350971-08229408> Playing 'tt-monkeys.gsm' (language 'en')
-- Executing [0303350971 at catchall:8]
ControlPlayback("SIP/0303350971-08229408", "tt-monkeys,,,,1234567890,,*")
in new stack
[Jan 30 11:26:43] WARNING[13022]: app_controlplayback.c:133
controlplayback_exec: args.fwd = #
[Jan 30 11:26:43] WARNING[13022]: app_controlplayback.c:146
controlplayback_exec: args.rew = NULL
-- <SIP/0303350971-08229408> Playing 'tt-monkeys.gsm' (language 'en')
-- Executing [0303350971 at catchall:9]
ControlPlayback("SIP/0303350971-08229408", "tt-monkeys,3000,,,*,,1") in new
stack
[Jan 30 11:26:59] WARNING[13022]: app_controlplayback.c:133
controlplayback_exec: args.fwd = #
[Jan 30 11:26:59] WARNING[13022]: app_controlplayback.c:146
controlplayback_exec: args.rew = NULL
-- <SIP/0303350971-08229408> Playing 'tt-monkeys.gsm' (language 'en')
-- Executing [0303350971 at catchall:10]
ControlPlayback("SIP/0303350971-08229408", "tt-monkeys,3000,,,,#,1") in new
stack
[Jan 30 11:27:15] WARNING[13022]: app_controlplayback.c:136
controlplayback_exec: args.fwd = NULL
[Jan 30 11:27:15] WARNING[13022]: app_controlplayback.c:143
controlplayback_exec: args.rew = *
-- <SIP/0303350971-08229408> Playing 'tt-monkeys.gsm' (language 'en')
-- Executing [0303350971 at catchall:11]
Hangup("SIP/0303350971-08229408", "") in new stack
== Spawn extension (catchall, 0303350971, 11) exited non-zero on
'SIP/0303350971-08229408'
Issue History
Date Modified Username Field Change
======================================================================
01-30-08 04:42 johan Note Added: 0081392
======================================================================
More information about the asterisk-bugs
mailing list