[asterisk-bugs] [Asterisk 0011662]: Proper Hebrew support for Asterisk

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11662 
====================================================================== 
Reported By:                greenfieldtech
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   11662
Category:                   Applications/app_voicemail
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 95577 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             01-01-2008 11:23 CST
Last Modified:              01-29-2008 14:14 CST
====================================================================== 
Summary:                    Proper Hebrew support for Asterisk
Description: 
The current Hebrew support in Asterisk is fairly incomplete, both in terms
of recordings and in term of proper Hebrew grammar. The following will
serve as a patch upload point for myself and Ido Kanner, to upload a patch
for proper Hebrew support. 
====================================================================== 

---------------------------------------------------------------------- 
 qwell - 01-29-08 14:14  
---------------------------------------------------------------------- 
There are still many significant coding guidelines violations in these
patches.  Use tabs rather than spaces where appropriate, no // style
comments, no nested if blocks without braces.

I also have several language concerns (not being a Hebrew speaker).  Near
the beginning of the voicemail patch, you change how it says "first
message", and it appears to have the potential to say "message first
message".  Near the end of the voicemail patch, you remove the saying of
the folder name.  You have several TODO comments sprinkled throughout about
saying "Shtei", and I'm unsure why that is.

You should not be using "digits/he/at", you should be using "digits/at"
like all the others. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
01-29-08 14:14  qwell          Note Added: 0081360                          
======================================================================