[asterisk-bugs] [Zaptel 0009948]: [patch] xpp_usb.o is not being added to the modules list to be built

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=9948 
====================================================================== 
Reported By:                james
Assigned To:                tzafrir
====================================================================== 
Project:                    Zaptel
Issue ID:                   9948
Category:                   Astribank (xpp)
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     assigned
Zaptel Version:             1.4.2  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        Yes 
Request Review:              
====================================================================== 
Date Submitted:             06-11-2007 16:55 CDT
Last Modified:              01-29-2008 13:42 CST
====================================================================== 
Summary:                    [patch] xpp_usb.o is not being added to the modules
list to be built
Description: 
It appears the ifneq is in outdated with latest zaptel release (1.4.3)
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0011530 Zaptel makefile will not install after ...
====================================================================== 

---------------------------------------------------------------------- 
 kpfleming - 01-29-08 13:42  
---------------------------------------------------------------------- 
I don't see any reason to avoid building xpp_usb just because the kernel
has CONFIG_USB turned off. The headers are still present, and if the user
reconfigures their kernel to have USB support (assuming they aren't using
modversions) then the already-built xpp_usb will work fine. If not, the
worst that will happen is that they will get warnings at install time and
failures if they try to intentionally load the module. If that bothers
them, they can use menuselect to avoid building xpp entirely. This is the
same situation that exists for wcusb.

How about we just simplify the Makefile to always build everything the
user has asked us to build, even if we could know that a given module
wouldn't work. That will close this issue and also eliminate any fragility
in the Makefiles depending on particulars of the kernel configuration. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
01-29-08 13:42  kpfleming      Note Added: 0081357                          
======================================================================