[asterisk-bugs] [Zaptel 0011523]: [patch] build issues on 2.6.8 - struct_device and wait_event_timeout

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11523 
====================================================================== 
Reported By:                tzafrir
Assigned To:                
====================================================================== 
Project:                    Zaptel
Issue ID:                   11523
Category:                   General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Zaptel Version:              SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.2  
SVN Revision (number only!): 3445 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             12-12-2007 03:10 CST
Last Modified:              01-25-2008 18:18 CST
====================================================================== 
Summary:                    [patch] build issues on 2.6.8 - struct_device and
wait_event_timeout
Description: 
There are several new warnings on the 2.6.8-3-686 kernel on Debian Sarge.

* wait_event_timeout is not present in kernel 2.6.8.

* The one in wctdm24xxp/GpakCust.c should be resolved by #include-ing
<linux/device.h> . This seems to have no ill-effect on building with later
kernels.

  CC [M] 
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctc4xxp/base.o
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctc4xxp/base.c:
In function `wcdte_waitfor_csmencaps':
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctc4xxp/base.c:1325:
warning: implicit declaration of function `wait_event_timeout'
  LD [M] 
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctc4xxp/wctc4xxp.o
  CC [M] 
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctdm24xxp/base.o
  CC [M] 
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctdm24xxp/GpakCust.o
In file included from
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctdm24xxp/GpakCust.h:42,
                 from
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctdm24xxp/GpakCust.c:45:
include/linux/firmware.h:11: warning: `struct device' declared inside
parameter list
include/linux/firmware.h:11: warning: its scope is only this definition or
declaration, which is probably not what you want
include/linux/firmware.h:15: warning: `struct device' declared inside
parameter list
  CC [M] 
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctdm24xxp/GpakApi.o
In file included from
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctdm24xxp/GpakCust.h:42,
                 from
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctdm24xxp/GpakApi.c:42:
include/linux/firmware.h:11: warning: `struct device' declared inside
parameter list
include/linux/firmware.h:11: warning: its scope is only this definition or
declaration, which is probably not what you want
include/linux/firmware.h:15: warning: `struct device' declared inside
parameter list
  LD [M] 
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctdm24xxp/wctdm24xxp.o
  CC [M] 
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wcte12xp/base.o
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wcte12xp/base.c:
In function `t1xxp_echocan':
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wcte12xp/base.c:1290:
warning: comparison of distinct pointer types lacks a cast

====================================================================== 

---------------------------------------------------------------------- 
 kpfleming - 01-25-08 18:18  
---------------------------------------------------------------------- 
The wait_event_timeout issue is still under discussion; if the driver
developer says that it is necessary, then this will become a 'wont fix'
because the code for wait_event_timeout from 2.6.9 may or may not work on
2.6.8 even if we were willing to duplicate the code in our source file. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
01-25-08 18:18  kpfleming      Note Added: 0081200                          
======================================================================