[asterisk-bugs] [Asterisk 0011827]: Add TCP socket support to app_externalivr.c

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11827 
====================================================================== 
Reported By:                ctooley
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   11827
Category:                   Applications/app_externalivr
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     new
Asterisk Version:           1.4.17 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             01-23-2008 15:15 CST
Last Modified:              01-23-2008 15:56 CST
====================================================================== 
Summary:                    Add TCP socket support to app_externalivr.c
Description: 
This change adds the ability to communicate over a TCP socket instead of
forking a child process.  Use by putting "ivr://eivrhost[:port]" in place
of the command inside ExternalIvr().
====================================================================== 

---------------------------------------------------------------------- 
 qwell - 01-23-08 15:56  
---------------------------------------------------------------------- 
There are also quite a few coding guidelines violations - especially in
eivr_connect_socket().  Mostly lack of spaces in function calls and single
line if's like "if (blah) do_stuff;".

I'd also like to see it avoid using goto in new functions if at all
possible (in the case of eivr_connect_socket(), it's only returning unit,
and not doing any cleanup type of stuff) 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
01-23-08 15:56  qwell          Note Added: 0081123                          
======================================================================