[asterisk-bugs] [Asterisk 0011802]: Make File- Warning out of order

[noreply at bugs.digium.com]

The following issue has been RESOLVED. 
====================================================================== 
http://bugs.digium.com/view.php?id=11802 
====================================================================== 
Reported By:                jfinstrom
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   11802
Category:                   Core/BuildSystem
Reproducibility:            always
Severity:                   text
Priority:                   normal
Status:                     resolved
Asterisk Version:           1.6.0-beta1 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 suspended
Fixed in Version:           
====================================================================== 
Date Submitted:             01-20-2008 16:54 CST
Last Modified:              01-21-2008 10:14 CST
====================================================================== 
Summary:                    Make File- Warning out of order
Description: 
The full warning should come after 551 to ensure it is seen and doesnt just
scroll past 


 540 oldmodcheck:
  541 	@if [ -n "$(OLDMODS)" ]; then \
  542 		echo " WARNING WARNING WARNING" ;\
  543 		echo "" ;\
  544 		echo " Your Asterisk modules directory, located at" ;\
  545 		echo " $(DESTDIR)$(MODULES_DIR)" ;\
  546 		echo " contains modules that were not installed by this " ;\
  547 		echo " version of Asterisk. Please ensure that these" ;\
  548 		echo " modules are compatible with this version before" ;\
  549 		echo " attempting to run Asterisk." ;\
  550 		echo "" ;\
  551 		for f in $(OLDMODS); do \
  552 			echo "    $$f" ;\
  553 		done ;\
  554 		echo "" ;\
  555 		echo " WARNING WARNING WARNING" ;\
  556 	fi
  557 
====================================================================== 

---------------------------------------------------------------------- 
 qwell - 01-21-08 10:14  
---------------------------------------------------------------------- 
I don't really understand how moving the text would help the situation at
all - in fact, if the reasons for moving it are because you *can't* scroll
up, then I could see this as being harmful.

Let's assume that you are able to see 16 lines on your screen.  The
warning itself takes up 11 of those lines, leaving 5 lines for modules. 
Let's say you have 10 modules that weren't compiled with Asterisk...  if
you move the warning text to below the modules, you can no longer see some
of the modules.  That's bad.

If the reason for this is just because people don't know that they need to
scroll up to see it, I think the "WARNING WARNING WARNING" at the end
serves as a pretty good indicator..


Closing.  Reopen if you think you can convince me. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
01-21-08 10:14  qwell          Note Added: 0080938                          
======================================================================