[asterisk-bugs] [Zaptel 0008290]: [patch] zap hookstate is never set offhook if wctdm module is loaded with an active fxo line

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=8290 
====================================================================== 
Reported By:                tmarkov
Assigned To:                kpfleming
====================================================================== 
Project:                    Zaptel
Issue ID:                   8290
Category:                   wctdm
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Zaptel Version:              1.2.10 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        Yes 
Request Review:              
====================================================================== 
Date Submitted:             11-03-2006 17:28 CST
Last Modified:              01-13-2008 14:54 CST
====================================================================== 
Summary:                    [patch] zap hookstate is never set offhook if wctdm
module is loaded with an active fxo line
Description: 
If #define ZAP_CHECK_HOOKSTATE is uncommented in chan_zap.c, then the
hookstate stays onhook if the wctdm module is loaded with an active line. 
Removing line and reinserting will cause the hookstate to initialize
properly.  The problem appears to be that wc->mod[card].fxo.battery never
gets initialized to 0, so in wctdm_voicedaa_check_hook() the test "if
(!wc->mod[card].fxo.battery && !wc->mod[card].fxo.battdebounce)" is never
entered, and the hookstate remains onhook upon module startup.  Only a
cycling of line voltage will correct the problem.  I have attached a patch
which initializes the battery variable and fixes the problem for me.
====================================================================== 

---------------------------------------------------------------------- 
 meneault - 01-13-08 14:54  
---------------------------------------------------------------------- 
Here you have the latest version of the patches needed to close the issue:
8290-alarm-wctdm-c_1_4_rev3682
8290-alarm-wctdm24xxp-base-c_1_4_rev3682

I didn't test these patches (I only compiled them) but they are only
updates of my other patches that I have already successfully tested.

Note:
Something related to zt_alarm_channel, it is better to lock on channel
when accessing chan->chan_alarms.
(it would only collide with ZT_GET_PARAM/ZT_GET_PARAMV1 ioctls without any
serious harm but it is safer to lock anyway)
take a look at  8290-alarm-zaptel-base-c_1_4_rev3682. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
01-13-08 14:54  meneault       Note Added: 0076865                          
======================================================================