[asterisk-bugs] [Asterisk 0011017]: [patch] zap restart fails to generate channels

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11017 
====================================================================== 
Reported By:                tzafrir
Assigned To:                kpfleming
====================================================================== 
Project:                    Asterisk
Issue ID:                   11017
Category:                   Channels/chan_zap
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 86182 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             10-17-2007 15:50 CDT
Last Modified:              01-11-2008 18:09 CST
====================================================================== 
Summary:                    [patch] zap restart fails to generate channels
Description: 
The command "zap restart" has been added before 1.4 . However at some point
it has been changed to run setup_zap(2) instead of setup_zap(0) . This
makes it useless, as it can only destroy channels and not create new ones.

The attached patch fixes this, as well as other implementation issues with
zap_restart:

* Just release all the interfaces at once. The same code as in the module
unload.

* Thus we also lock the iflist when destroying channel.

* If we were listening on some file descriptors and now we don't, pfds was
still pointing to a value even though its value has been released.


With this patch a restart of analog channels work. A restart of digital
spans still fails, as there is no where in the code that D channels are
being released.
====================================================================== 

---------------------------------------------------------------------- 
 tzafrir - 01-11-08 18:09  
---------------------------------------------------------------------- 
The channels are busy. In that case running 'zap restart' twice would do
the trick.

Again, this is the case of non-PRI channels only. In the case of PRIs, the
D channel is never properly closed. And will never be properly
re-initialized. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
01-11-08 18:09  tzafrir        Note Added: 0076776                          
======================================================================