[asterisk-bugs] [Zaptel 0009264]: [patch] wctdm sometimes misses callerid

[noreply at bugs.digium.com]

The following issue has been ASSIGNED. 
====================================================================== 
http://bugs.digium.com/view.php?id=9264 
====================================================================== 
Reported By:                mjagdis
Assigned To:                kpfleming
====================================================================== 
Project:                    Zaptel
Issue ID:                   9264
Category:                   wctdm
Reproducibility:            sometimes
Severity:                   minor
Priority:                   normal
Status:                     assigned
Zaptel Version:             1.4.7.1 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Disclaimer on File?:        Yes 
Request Review:              
====================================================================== 
Date Submitted:             03-13-2007 08:12 CDT
Last Modified:              01-11-2008 17:35 CST
====================================================================== 
Summary:                    [patch] wctdm sometimes misses callerid
Description: 
When caller ID is sent before the first ring and preceeded by a polarity
reversal (e.g. UK) the reversal sometimes causes the wctdm to report a
"phantom" ring which aborts/prevents the read of the callerid.

This is documented in the Si3050 specs. The recommended method of handling
ring recognition in the presence of polarity reverals is to put the ring
detector in full-wave rectification mode and watch for a leading _and_
trailing edge in the received ring tone.

The attached patch implements the recommended method. Without it I could
trigger a missed clid in just 3 or 4 attempts. With it I can't trigger a
missed clid at all.
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 01-11-08 17:35  
---------------------------------------------------------------------- 
Repository: zaptel
Revision: 3674

U   branches/1.4/wctdm.c
U   branches/1.4/wctdm24xxp/base.c
U   branches/1.4/wctdm24xxp/wctdm24xxp.h

------------------------------------------------------------------------
r3674 | kpfleming | 2008-01-11 17:35:30 -0600 (Fri, 11 Jan 2008) | 8 lines

Improve ring detection when polarity reversals are present.

(closes issue http://bugs.digium.com/view.php?id=9264)
Reported by: mjagdis
Patches:
      zaptel-ring.diff uploaded by mjagdis (modified by me to add support
in wctdm24xxp as well)
Tested by: benbrown

------------------------------------------------------------------------

http://svn.digium.com/view/zaptel?view=rev&revision=3674 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
01-11-08 17:35  svnbot         Checkin                                      
01-11-08 17:35  svnbot         Note Added: 0076767                          
01-11-08 17:35  svnbot         Assigned To              mattf => kpfleming  
======================================================================